Merge pull request #56128 from jmarolf/bugfix/do-not-show-ui-for-external-files

Author: jmarolf

src/VisualStudio/Core/Def/EditorConfigSettings/SettingsEditorFactory.cs

@@ -63,7 +63,7 @@ public void Dispose()
         }
 
         public int CreateEditorInstance(uint grfCreateDoc,
-                                        string pszMkDocument,
+                                        string filePath,
                                         string pszPhysicalView,
                                         IVsHierarchy pvHier,
                                         uint itemid,
@@ -88,6 +88,12 @@ public int CreateEditorInstance(uint grfCreateDoc,
                 return VSConstants.VS_E_UNSUPPORTEDFORMAT;
             }
 
+            if (!_workspace.CurrentSolution.Projects.Any(p => p.AnalyzerConfigDocuments.Any(editorconfig => StringComparer.OrdinalIgnoreCase.Equals(editorconfig.FilePath, filePath))))
+            {
+                // If the user is simply opening an editorconfig file that does not apply to the current solution we just want to show the text view
+                return VSConstants.VS_E_UNSUPPORTEDFORMAT;
+            }
+
             // Validate inputs
             if ((grfCreateDoc & (VSConstants.CEF_OPENFILE | VSConstants.CEF_SILENT)) == 0)
             {
@@ -138,7 +144,7 @@ public int CreateEditorInstance(uint grfCreateDoc,
                                                    _settingsDataProviderFactory,
                                                    _controlProvider,
                                                    _tableMangerProvider,
-                                                   pszMkDocument,
+                                                   filePath,
                                                    textBuffer,
                                                    _workspace);
             ppunkDocView = Marshal.GetIUnknownForObject(newEditor);