Skip to content

Commit 569f8df

Browse files
author
Julien Couvreur
committed
Use 78960 for follow-ups related to collection expressions
1 parent 6cf9c73 commit 569f8df

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/Compilers/CSharp/Portable/Binder/Binder_Conversions.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1467,7 +1467,7 @@ static ImmutableArray<MethodSymbol> filterOutBadGenericMethods(
14671467

14681468
if (!typeParameters.IsEmpty)
14691469
{
1470-
if (resolution.IsExtensionMethodGroup) // Tracked by https://github.com/dotnet/roslyn/issues/76130 : we need to handle new extension methods
1470+
if (resolution.IsExtensionMethodGroup) // Tracked by https://github.com/dotnet/roslyn/issues/78960 : we need to handle new extension methods
14711471
{
14721472
// We need to validate an ability to infer type arguments as well as check conversion to 'this' parameter.
14731473
// Overload resolution doesn't check the conversion when 'this' type refers to a type parameter
@@ -1518,7 +1518,7 @@ static ImmutableArray<MethodSymbol> filterOutBadGenericMethods(
15181518
parameterTypes,
15191519
parameterRefKinds,
15201520
ImmutableArray.Create<BoundExpression>(methodGroup.ReceiverOpt, new BoundValuePlaceholder(syntax, secondArgumentType) { WasCompilerGenerated = true }),
1521-
ref useSiteInfo); // Tracked by https://github.com/dotnet/roslyn/issues/76130 : we may need to override ordinals here
1521+
ref useSiteInfo); // Tracked by https://github.com/dotnet/roslyn/issues/78960 : we may need to override ordinals here
15221522

15231523
if (!inferenceResult.Success)
15241524
{
@@ -1601,7 +1601,7 @@ static bool bindInvocationExpressionContinued(
16011601
var methodResult = result.ValidResult;
16021602
var method = methodResult.Member;
16031603

1604-
// Tracked by https://github.com/dotnet/roslyn/issues/76130: It looks like we added a bunch of code in BindInvocationExpressionContinued at this position
1604+
// Tracked by https://github.com/dotnet/roslyn/issues/78960: It looks like we added a bunch of code in BindInvocationExpressionContinued at this position
16051605
// that specifically deals with new extension methods. It adjusts analyzedArguments, etc.
16061606
// It is very likely we need to do the same here.
16071607

@@ -1663,7 +1663,7 @@ internal static BoundExpression GetUnderlyingCollectionExpressionElement(BoundCo
16631663
// Add methods. This case can be hit for spreads and non-spread elements.
16641664
Debug.Assert(call.HasErrors);
16651665
Debug.Assert(call.Method.Name == "Add");
1666-
return call.Arguments[call.InvokedAsExtensionMethod ? 1 : 0]; // Tracked by https://github.com/dotnet/roslyn/issues/76130: Add test coverage for new extensions
1666+
return call.Arguments[call.InvokedAsExtensionMethod ? 1 : 0]; // Tracked by https://github.com/dotnet/roslyn/issues/78960: Add test coverage for new extensions
16671667
case BoundBadExpression badExpression:
16681668
Debug.Assert(false); // Add test if we hit this assert.
16691669
return badExpression;
@@ -1712,7 +1712,7 @@ internal bool TryGetCollectionIterationType(SyntaxNode syntax, TypeSymbol collec
17121712
out iterationType,
17131713
builder: out var builder);
17141714
// Collection expression target types require instance method GetEnumerator.
1715-
if (result && builder.ViaExtensionMethod) // Tracked by https://github.com/dotnet/roslyn/issues/76130: Add test coverage for new extensions
1715+
if (result && builder.ViaExtensionMethod) // Tracked by https://github.com/dotnet/roslyn/issues/78960: Add test coverage for new extensions
17161716
{
17171717
iterationType = default;
17181718
return false;

0 commit comments

Comments
 (0)