Stop showing smart tags for subsequent 'Unnecessary' diagnostics

Author: jnm2

src/Features/Core/Portable/SimplifyInterpolation/AbstractSimplifyInterpolationDiagnosticAnalyzer.cs

@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Collections.Immutable;
+using System.Linq;
 using Microsoft.CodeAnalysis.CodeStyle;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.EmbeddedLanguages.VirtualChars;
@@ -63,18 +64,16 @@ private void AnalyzeInterpolation(OperationAnalysisContext context)
                 return;
             }
 
-            var locations = ImmutableArray.Create(interpolation.Syntax.GetLocation());
+            context.ReportDiagnostic(DiagnosticHelper.Create(
+                UnnecessaryWithSuggestionDescriptor,
+                unnecessaryLocations.First(),
+                option.Notification.Severity,
+                additionalLocations: ImmutableArray.Create(interpolation.Syntax.GetLocation()),
+                properties: null));
 
-            var severity = option.Notification.Severity;
-
-            for (var i = 0; i < unnecessaryLocations.Length; i++)
+            foreach (var subsequentLocation in unnecessaryLocations.Skip(1))
             {
-                context.ReportDiagnostic(DiagnosticHelper.Create(
-                    i == 0 ? UnnecessaryWithSuggestionDescriptor : UnnecessaryWithoutSuggestionDescriptor,
-                    unnecessaryLocations[i],
-                    severity,
-                    additionalLocations: locations,
-                    properties: null));
+                context.ReportDiagnostic(Diagnostic.Create(UnnecessaryWithoutSuggestionDescriptor, subsequentLocation));
             }
         }
     }