Merge remote-tracking branch 'upstream/main' into merges/main-to-features/param-nullchecking

Author: RikkiGibson

.vscode/settings.json

@@ -0,0 +1,5 @@
+{
+    "files.associations": {
+        "**/eng/pipelines/*.yml": "azure-pipelines"
+    }
+}

Roslyn.sln

@@ -501,6 +501,9 @@ EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Remote.ServiceHub.UnitTests", "src\Workspaces\Remote\ServiceHubTest\Microsoft.CodeAnalysis.Remote.ServiceHub.UnitTests.csproj", "{8D830CBB-CA6E-47D8-9FB8-9230AAD272F3}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.VisualStudio.LanguageServices.New.IntegrationTests", "src\VisualStudio\IntegrationTest\New.IntegrationTests\Microsoft.VisualStudio.LanguageServices.New.IntegrationTests.csproj", "{6272739B-31E4-483E-A3A5-2ABB5040ABF0}"
+	ProjectSection(ProjectDependencies) = postProject
+		{201EC5B7-F91E-45E5-B9F2-67A266CCE6FC} = {201EC5B7-F91E-45E5-B9F2-67A266CCE6FC}
+	EndProjectSection
 EndProject
 Global
 	GlobalSection(SharedMSBuildProjectFiles) = preSolution

Verify.cmd

@@ -0,0 +1,2 @@
+@echo off
+powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0eng\build.ps1""" -build -restore -rebuild -pack -test -runAnalyzers -warnAsError %*"

azure-pipelines-integration-dartlab.yml

@@ -0,0 +1,62 @@
+# Roslyn integration test pipeline for validating against branch builds of VS.
+
+trigger: none # Manual trigger for now
+
+resources:
+  pipelines:
+  - pipeline: VisualStudioBuildUnderTest
+    source: DD-CB-ReleaseVS
+    branch: main
+  - pipeline: DartLab
+    source: DartLab
+    branch: main
+  repositories:
+  - repository: DartLabTemplates
+    type: git
+    name: DartLab.Templates
+    ref: refs/heads/dev/bradwhit/RemoveCheckoutNone
+
+variables:
+- name: XUNIT_LOGS
+  value: $(Build.SourcesDirectory)\artifacts\log\$(_configuration)
+
+stages:
+- template: \stages\visual-studio\base.yml@DartLabTemplates
+  parameters:
+    displayName: VS Integration
+    testLabPoolName: VS-Platform2
+    visualStudioBootstrapperURI: https://vsdrop.corp.microsoft.com/file/v1/$(VisualStudio.BuildUnderTest.ProductsDropName);bootstrappers/Enterprise/vs_enterprise.exe
+    visualStudioInstallationParameters: --add Microsoft.VisualStudio.Component.NuGet --add Microsoft.VisualStudio.Component.Roslyn.Compiler --add Microsoft.Component.MSBuild --add Microsoft.NetCore.Component.Runtime.6.0 --add Microsoft.NetCore.Component.SDK --add Microsoft.Net.Component.4.7.2.TargetingPack --add Microsoft.VisualStudio.Component.Roslyn.LanguageServices --add Microsoft.VisualStudio.Component.FSharp --add Microsoft.ComponentGroup.ClickOnce.Publish --add Microsoft.NetCore.Component.DevelopmentTools --add Microsoft.VisualStudio.Component.MSODBC.SQL --add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils --add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime --add Microsoft.VisualStudio.Component.SQL.CLR --add Microsoft.VisualStudio.Component.CoreEditor --add Microsoft.VisualStudio.Workload.CoreEditor --add Microsoft.Net.Component.4.8.SDK --add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites --add Microsoft.VisualStudio.Component.TypeScript.TSServer --add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions --add Microsoft.VisualStudio.Component.JavaScript.TypeScript --add Microsoft.VisualStudio.Component.JavaScript.Diagnostics --add Microsoft.VisualStudio.Component.TextTemplating --add Component.Microsoft.VisualStudio.RazorExtension --add Microsoft.VisualStudio.Component.IISExpress --add Microsoft.VisualStudio.Component.Common.Azure.Tools --add Microsoft.Component.ClickOnce --add Microsoft.VisualStudio.Component.ManagedDesktop.Core --add Microsoft.VisualStudio.Component.SQL.SSDT --add Microsoft.VisualStudio.Component.SQL.DataSources --add Component.Microsoft.Web.LibraryManager --add Component.Microsoft.WebTools.BrowserLink.WebLivePreview --add Microsoft.VisualStudio.ComponentGroup.Web --add Microsoft.VisualStudio.Component.FSharp.WebTemplates --add Microsoft.VisualStudio.Component.DockerTools --add Microsoft.NetCore.Component.Web --add Microsoft.VisualStudio.Component.WebDeploy --add Microsoft.VisualStudio.Component.AppInsights.Tools --add Microsoft.VisualStudio.Component.Web --add Microsoft.Net.Component.4.8.TargetingPack --add Microsoft.Net.ComponentGroup.4.8.DeveloperTools --add Microsoft.VisualStudio.Component.AspNet45 --add Microsoft.VisualStudio.Component.AspNet --add Component.Microsoft.VisualStudio.Web.AzureFunctions --add Microsoft.VisualStudio.ComponentGroup.AzureFunctions --add Microsoft.VisualStudio.Component.Debugger.Snapshot --add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools --add Microsoft.VisualStudio.Component.IntelliTrace.FrontEnd --add Microsoft.VisualStudio.Component.DiagnosticTools --add Microsoft.VisualStudio.Component.EntityFramework --add Microsoft.VisualStudio.Component.LiveUnitTesting --add Microsoft.VisualStudio.Component.Debugger.JustInTime --add Component.Microsoft.VisualStudio.LiveShare.2022 --add Microsoft.VisualStudio.Component.WslDebugging --add Microsoft.VisualStudio.Component.IntelliCode --add Microsoft.VisualStudio.Workload.NetWeb --add Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites --add Microsoft.ComponentGroup.Blend --add Microsoft.VisualStudio.Component.DotNetModelBuilder --add Microsoft.VisualStudio.Component.FSharp.Desktop --add Microsoft.VisualStudio.Component.PortableLibrary --add Microsoft.VisualStudio.Workload.ManagedDesktop --add Microsoft.Net.Component.4.6.TargetingPack --add Microsoft.VisualStudio.Component.VSSDK --add Microsoft.VisualStudio.ComponentGroup.VisualStudioExtension.Prerequisites --add Microsoft.Component.CodeAnalysis.SDK --add Microsoft.VisualStudio.Workload.VisualStudioExtension --installPath "C:\Test\VisualStudio" --quiet --norestart --wait
+    testExecutionJobStrategy:
+      maxParallel: 4
+      matrix:
+        debug_32:
+          _configuration: Debug
+          _oop64bit: false
+        debug_64:
+          _configuration: Debug
+          _oop64bit: true
+        release_32:
+          _configuration: Release
+          _oop64bit: false
+        release_64:
+          _configuration: Release
+          _oop64bit: true
+    testMachineTotalCount: 4
+    testAgentElevated: true
+    preTestMachineConfigurationStepList:
+    - checkout: none
+    - download: VisualStudioBuildUnderTest
+    - task: PowerShell@2
+      name: SetProductsDropName
+      displayName: Set 'VisualStudio.BuildUnderTest.ProductsDropName'
+      inputs:
+        filePath: $(DartLab.Path)\Scripts\VisualStudio\Build\Get-VisualStudioDropName.ps1
+        arguments: -DropNamePrefix 'Products' -VstsDropUrlsJson '$(Pipeline.Workspace)\VisualStudioBuildUnderTest\BuildArtifacts\VstsDropUrls.json' -OutVariableName 'VisualStudio.BuildUnderTest.ProductsDropName'
+    deployAndRunTestsStepList:
+    - template: eng/pipelines/test-integration-job.yml
+      parameters:
+        configuration: $(_configuration)
+        oop64bit: $(_oop64bit)
+        lspEditor: false
+        shallowCheckout: false

azure-pipelines-official.yml

@@ -68,11 +68,11 @@ stages:
   displayName: Build and Test
 
   jobs:
-  - ${{ if eq(variables['Build.SourceBranch'], 'refs/heads/release/dev17.0-vs-deps') }}:
+  - ${{ if eq(variables['Build.SourceBranch'], 'refs/heads/release/dev17.1-vs-deps') }}:
     - template: /eng/common/templates/job/onelocbuild.yml
       parameters:
         MirrorRepo: roslyn
-        MirrorBranch: release/dev17.0-vs-deps
+        MirrorBranch: release/dev17.1-vs-deps
         LclSource: lclFilesfromPackage
         LclPackageId: 'LCL-JUNO-PROD-ROSLYN'
 

azure-pipelines.yml

@@ -30,14 +30,15 @@ jobs:
     configuration: Release
     queueName: Build.Windows.Amd64.VS2022.Pre.Open
 
-- template: eng/pipelines/test-windows-job.yml
-  parameters:
-    testRunName: 'Test Windows Desktop Debug 32'
-    jobName: Test_Windows_Desktop_Debug_32
-    buildJobName: Build_Windows_Debug
-    testArtifactName: Transport_Artifacts_Windows_Debug
-    configuration: Debug
-    testArguments: -testDesktop -test32
+- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
+  - template: eng/pipelines/test-windows-job.yml
+    parameters:
+      testRunName: 'Test Windows Desktop Debug 32'
+      jobName: Test_Windows_Desktop_Debug_32
+      buildJobName: Build_Windows_Debug
+      testArtifactName: Transport_Artifacts_Windows_Debug
+      configuration: Debug
+      testArguments: -testDesktop -test32
 
 - template: eng/pipelines/test-windows-job.yml
   parameters:
@@ -57,14 +58,15 @@ jobs:
     configuration: Debug
     testArguments: -testCoreClr
 
-- template: eng/pipelines/test-windows-job-single-machine.yml
-  parameters:
-    testRunName: 'Test Windows CoreClr Debug Single Machine'
-    jobName: Test_Windows_CoreClr_Debug_Single_Machine
-    buildJobName: Build_Windows_Debug
-    testArtifactName: Transport_Artifacts_Windows_Debug
-    configuration: Debug
-    testArguments: -testCoreClr
+- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
+  - template: eng/pipelines/test-windows-job-single-machine.yml
+    parameters:
+      testRunName: 'Test Windows CoreClr Debug Single Machine'
+      jobName: Test_Windows_CoreClr_Debug_Single_Machine
+      buildJobName: Build_Windows_Debug
+      testArtifactName: Transport_Artifacts_Windows_Debug
+      configuration: Debug
+      testArguments: -testCoreClr
 
 - template: eng/pipelines/test-windows-job.yml
   parameters:
@@ -77,21 +79,22 @@ jobs:
 
 - template: eng/pipelines/test-windows-job.yml
   parameters:
-    testRunName: 'Test Windows Desktop Spanish Release 32'
-    jobName: Test_Windows_Desktop_Spanish_Release_32
+    testRunName: 'Test Windows Desktop Spanish Release 64'
+    jobName: Test_Windows_Desktop_Spanish_Release_64
     buildJobName: Build_Windows_Release
     testArtifactName: Transport_Artifacts_Windows_Release
     configuration: Release
-    testArguments: -testDesktop -test32 -helixQueueName Windows.10.Amd64.Server19H1.ES.Open
-
-- template: eng/pipelines/test-windows-job.yml
-  parameters:
-    testRunName: 'Test Windows Desktop Release 64'
-    jobName: Test_Windows_Desktop_Release_64
-    buildJobName: Build_Windows_Release
-    testArtifactName: Transport_Artifacts_Windows_Release
-    configuration: Release
-    testArguments: -testDesktop -test64
+    testArguments: -testDesktop -test64 -helixQueueName Windows.10.Amd64.Server19H1.ES.Open
+
+- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
+  - template: eng/pipelines/test-windows-job.yml
+    parameters:
+      testRunName: 'Test Windows Desktop Release 64'
+      jobName: Test_Windows_Desktop_Release_64
+      buildJobName: Build_Windows_Release
+      testArtifactName: Transport_Artifacts_Windows_Release
+      configuration: Release
+      testArguments: -testDesktop -test64
 
 - template: eng/pipelines/test-windows-job.yml
   parameters:
@@ -128,15 +131,16 @@ jobs:
     configuration: Debug
     testArguments: --testCoreClr --helixQueueName Ubuntu.1804.Amd64.Open
 
-- template: eng/pipelines/test-unix-job-single-machine.yml
-  parameters:
-    testRunName: 'Test Linux Debug Single Machine'
-    jobName: Test_Linux_Debug_Single_Machine
-    buildJobName: Build_Unix_Debug
-    testArtifactName: Transport_Artifacts_Unix_Debug
-    configuration: Debug
-    testArguments: --testCoreClr
-    queueName: 'Build.Ubuntu.1804.amd64.Open'
+- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
+  - template: eng/pipelines/test-unix-job-single-machine.yml
+    parameters:
+      testRunName: 'Test Linux Debug Single Machine'
+      jobName: Test_Linux_Debug_Single_Machine
+      buildJobName: Build_Unix_Debug
+      testArtifactName: Transport_Artifacts_Unix_Debug
+      configuration: Debug
+      testArguments: --testCoreClr
+      queueName: 'Build.Ubuntu.1804.amd64.Open'
 
 - template: eng/pipelines/test-unix-job.yml
   parameters:

docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md

@@ -35,7 +35,6 @@
     }
     ```
 
-
 3. In Visual Studio 17.1, `ref`/`ref readonly`/`in`/`out` are not allowed to be used on return/parameters of a method attributed with `UnmanagedCallersOnly`.  
 https://github.com/dotnet/roslyn/issues/57025
 
@@ -56,3 +55,25 @@ https://github.com/dotnet/roslyn/issues/57025
     [UnmanagedCallersOnly]
     static void M5(out int o) => throw null; // error CS8977: Cannot use 'ref', 'in', or 'out' in a method attributed with 'UnmanagedCallersOnly'.
     ```
+
+4. Beginning with C# 11.0, `Length` and `Count` properties on countable and indexable types
+are assumed to be non-negative for purpose of subsumption and exhaustiveness analysis of patterns and switches.
+Those types can be used with implicit Index indexer and list patterns.
+
+    ```csharp
+    void M(int[] i)
+    {
+        if (i is { Length: -1 }) {} // error: impossible under assumption of non-negative length
+    }
+    ```
+
+5. Starting with Visual Studio 17.1, format specifiers in interpolated strings can not contain curly braces (either `{` or `}`). In previous versions `{{` was interpreted as an escaped `{` and `}}` was interpreted as an escaped `}` char in the format specifier. Now the first `}` char in a format specifier ends the interpolation, and any `{` char is an error.
+https://github.com/dotnet/roslyn/issues/5775
+
+```csharp
+using System;
+
+Console.WriteLine($"{{{12:X}}}");
+
+//prints now: "{C}" - not "{X}}"
+```

docs/compilers/CSharp/Warnversion Warning Waves.md

@@ -33,3 +33,4 @@ The table below describes all of the warnings controlled by warning levels `5` o
 | CS8892 | 5 | [Multiple entry points](https://github.com/dotnet/roslyn/issues/46831) |
 | CS8897 | 5 | [Static class used as the parameter type of a method in an interface type](https://github.com/dotnet/roslyn/issues/38256) |
 | CS8898 | 5 | [Static class used as the return type of a method in an interface type](https://github.com/dotnet/roslyn/issues/38256) |
+| CS8981 | 7 | [Type names only containing lower-cased ascii characters may become reserved for the language](https://github.com/dotnet/roslyn/issues/56653) |

docs/contributing/Building, Debugging, and Testing on Unix.md

@@ -1,6 +1,6 @@
 # Building, Debugging and Testing on Unix
-This guide is meant to help developers setup an environment for debugging / contributing to Roslyn from Linux. 
-Particularly for developers who aren't experienced with .NET Core development on Linux. 
+This guide is meant to help developers setup an environment for debugging / contributing to Roslyn from Linux.
+Particularly for developers who aren't experienced with .NET Core development on Linux.
 
 ## Working with the code
 1. Ensure the commands `git` and `curl` are available
@@ -12,7 +12,7 @@ Particularly for developers who aren't experienced with .NET Core development on
 1. Install [VS Code](https://code.visualstudio.com/Download)
     - After you install VS Code, install the [C# extension](https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp)
     - Important tip: You can look up editor commands by name by hitting *Ctrl+Shift+P*, or by hitting *Ctrl+P* and typing a `>` character. This will help you get familiar with editor commands mentioned below. On a Mac, use *⌘* instead of *Ctrl*.
-2. Install the [.NET 6.0 RC 2 SDK](https://dotnet.microsoft.com/download/dotnet-core/6.0).
+2. Install the [.NET 6.0 SDK](https://dotnet.microsoft.com/download/dotnet-core/6.0).
 3. You can build from VS Code by running the *Run Build Task* command, then selecting an appropriate task such as *build* or *build current project* (the latter builds the containing project for the current file you're viewing in the editor).
 4. You can run tests from VS Code by opening a test class in the editor, then using the *Run Tests in Context* and *Debug Tests in Context* editor commands. You may want to bind these commands to keyboard shortcuts that match their Visual Studio equivalents (**Ctrl+R, T** for *Run Tests in Context* and **Ctrl+R, Ctrl+T** for *Debug Tests in Context*).
 
@@ -23,14 +23,14 @@ To run all tests in a single project, it's recommended to use the `dotnet test p
 
 ## GitHub
 The best way to clone and push is to use SSH. On Windows you typically use HTTPS and this is not directly compatible
-with two factor authentication (requires a PAT). The SSH setup is much simpler and GitHub has a great HOWTO for 
+with two factor authentication (requires a PAT). The SSH setup is much simpler and GitHub has a great HOWTO for
 getting this setup.
 
 https://help.github.com/articles/connecting-to-github-with-ssh/
 
 ## Debugging test failures
 The best way to debug is using lldb with the SOS plugin. This is the same SOS as used in WinDbg and if you're familiar
-with it then lldb debugging will be pretty straight forward. 
+with it then lldb debugging will be pretty straight forward.
 
 The [dotnet/diagnostics](https://github.com/dotnet/diagnostics) repo has more information:
 
@@ -45,10 +45,10 @@ CoreCLR also has some guidelines for specific Linux debugging scenarios:
 
 Corrections:
 - LLDB and createdump must be run as root
-- `dotnet tool install -g dotnet-symbol` must be run from `$HOME` 
+- `dotnet tool install -g dotnet-symbol` must be run from `$HOME`
 
 ### Core Dumps
-The CoreClr does not used the standard core dumping mechanisms on Linux. Instead you must specify via 
+The CoreClr does not used the standard core dumping mechanisms on Linux. Instead you must specify via
 environment variables that you want a core dump to be produced. The simplest setup is to do the following:
 
 ```
@@ -79,12 +79,12 @@ indeed crashing in the GC.
 Note: this variables can also be used on Windows as well.
 
 ## Ubuntu 18.04
-The recommended OS for developing Roslyn is Ubuntu 18.04. This guide was written using Ubuntu 18.04 but should be 
+The recommended OS for developing Roslyn is Ubuntu 18.04. This guide was written using Ubuntu 18.04 but should be
 applicable to most Linux environments. Ubuntu 18.04 was chosen here due to it's support for enhanced VMs in Hyper-V.
 This makes it easier to use from a Windows machine: full screen, copy / paste, etc ...
 
 ### Hyper-V
-Hyper-V has a builtin Ubuntu 18.04 image which supports enhanced mode. Here is a tutorial for creating 
+Hyper-V has a builtin Ubuntu 18.04 image which supports enhanced mode. Here is a tutorial for creating
 such an image:
 
 https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/quick-start/quick-create-virtual-machine
@@ -93,10 +93,10 @@ When following this make sure to:
 1. Click Installation Source and uncheck "Windows Secure Boot"
 1. Complete the Ubuntu installation wizard. Full screen mode won't be available until this is done.
 
-Overall this takes about 5-10 minutes to complete. 
+Overall this takes about 5-10 minutes to complete.
 
 ### Source Link
-Many of the repositories that need to be built use source link and it crashes on Ubuntu 18.04 due to dependency changes. 
+Many of the repositories that need to be built use source link and it crashes on Ubuntu 18.04 due to dependency changes.
 To disable source link add the following to the `Directory.Build.props` file in the root of the repository.
 
 ``` xml
@@ -109,6 +109,6 @@ To disable source link add the following to the `Directory.Build.props` file in
 Make sure to install the following via `apt install`
 
 - clang
-- lldb 
+- lldb
 - cmake
 - xrdp