Fix nullable annotations of SymbolDisplay.FormatPrimitive (#79869)

jjonescz · web-flow · commit a523b8425cc9 · 2025-08-14T11:41:30.000+02:00
* Fix nullable annotations of `SymbolDisplay.FormatPrimitive`

* Remove unnecessary breaking change doc

* Mark as removed instead of removing
diff --git a/src/Compilers/CSharp/Portable/PublicAPI.Unshipped.txt b/src/Compilers/CSharp/Portable/PublicAPI.Unshipped.txt
@@ -53,6 +53,8 @@ override Microsoft.CodeAnalysis.CSharp.Syntax.ExtensionBlockDeclarationSyntax.Se
 override Microsoft.CodeAnalysis.CSharp.Syntax.ExtensionBlockDeclarationSyntax.TypeParameterList.get -> Microsoft.CodeAnalysis.CSharp.Syntax.TypeParameterListSyntax?
 override Microsoft.CodeAnalysis.CSharp.Syntax.ExtensionMemberCrefSyntax.Accept(Microsoft.CodeAnalysis.CSharp.CSharpSyntaxVisitor! visitor) -> void
 override Microsoft.CodeAnalysis.CSharp.Syntax.ExtensionMemberCrefSyntax.Accept<TResult>(Microsoft.CodeAnalysis.CSharp.CSharpSyntaxVisitor<TResult>! visitor) -> TResult?
+*REMOVED*static Microsoft.CodeAnalysis.CSharp.SymbolDisplay.FormatPrimitive(object! obj, bool quoteStrings, bool useHexadecimalNumbers) -> string!
+static Microsoft.CodeAnalysis.CSharp.SymbolDisplay.FormatPrimitive(object? obj, bool quoteStrings, bool useHexadecimalNumbers) -> string?
 static Microsoft.CodeAnalysis.CSharp.SyntaxFactory.ExtensionBlockDeclaration() -> Microsoft.CodeAnalysis.CSharp.Syntax.ExtensionBlockDeclarationSyntax!
 static Microsoft.CodeAnalysis.CSharp.SyntaxFactory.ExtensionBlockDeclaration(Microsoft.CodeAnalysis.SyntaxList<Microsoft.CodeAnalysis.CSharp.Syntax.AttributeListSyntax!> attributeLists, Microsoft.CodeAnalysis.SyntaxTokenList modifiers, Microsoft.CodeAnalysis.CSharp.Syntax.TypeParameterListSyntax? typeParameterList, Microsoft.CodeAnalysis.CSharp.Syntax.ParameterListSyntax? parameterList, Microsoft.CodeAnalysis.SyntaxList<Microsoft.CodeAnalysis.CSharp.Syntax.TypeParameterConstraintClauseSyntax!> constraintClauses, Microsoft.CodeAnalysis.SyntaxList<Microsoft.CodeAnalysis.CSharp.Syntax.MemberDeclarationSyntax!> members) -> Microsoft.CodeAnalysis.CSharp.Syntax.ExtensionBlockDeclarationSyntax!
 static Microsoft.CodeAnalysis.CSharp.SyntaxFactory.ExtensionBlockDeclaration(Microsoft.CodeAnalysis.SyntaxList<Microsoft.CodeAnalysis.CSharp.Syntax.AttributeListSyntax!> attributeLists, Microsoft.CodeAnalysis.SyntaxTokenList modifiers, Microsoft.CodeAnalysis.SyntaxToken keyword, Microsoft.CodeAnalysis.CSharp.Syntax.TypeParameterListSyntax? typeParameterList, Microsoft.CodeAnalysis.CSharp.Syntax.ParameterListSyntax? parameterList, Microsoft.CodeAnalysis.SyntaxList<Microsoft.CodeAnalysis.CSharp.Syntax.TypeParameterConstraintClauseSyntax!> constraintClauses, Microsoft.CodeAnalysis.SyntaxToken openBraceToken, Microsoft.CodeAnalysis.SyntaxList<Microsoft.CodeAnalysis.CSharp.Syntax.MemberDeclarationSyntax!> members, Microsoft.CodeAnalysis.SyntaxToken closeBraceToken, Microsoft.CodeAnalysis.SyntaxToken semicolonToken) -> Microsoft.CodeAnalysis.CSharp.Syntax.ExtensionBlockDeclarationSyntax!
diff --git a/src/Compilers/CSharp/Portable/SymbolDisplay/ObjectDisplay.cs b/src/Compilers/CSharp/Portable/SymbolDisplay/ObjectDisplay.cs
@@ -2,9 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
-
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Reflection;
 using Microsoft.CodeAnalysis.PooledObjects;
@@ -35,7 +34,7 @@ internal static class ObjectDisplay
         /// <see cref="long"/>, <see cref="ulong"/>, <see cref="double"/>, <see cref="float"/>, <see cref="decimal"/>,
         /// and <c>null</c>.
         /// </remarks>
-        public static string FormatPrimitive(object obj, ObjectDisplayOptions options)
+        public static string? FormatPrimitive(object? obj, ObjectDisplayOptions options)
         {
             if (obj == null)
             {
@@ -138,7 +137,7 @@ internal static string FormatLiteral(bool value)
         /// Returns true if the character should be replaced and sets
         /// <paramref name="replaceWith"/> to the replacement text.
         /// </summary>
-        private static bool TryReplaceChar(char c, out string replaceWith)
+        private static bool TryReplaceChar(char c, [NotNullWhen(returnValue: true)] out string? replaceWith)
         {
             replaceWith = null;
             switch (c)
@@ -332,7 +331,7 @@ internal static string FormatLiteral(char c, ObjectDisplayOptions options)
                 builder.Append(quote);
             }
 
-            string replaceWith;
+            string? replaceWith;
             if (escapeNonPrintable && TryReplaceChar(c, out replaceWith))
             {
                 builder.Append(replaceWith);
@@ -355,7 +354,7 @@ internal static string FormatLiteral(char c, ObjectDisplayOptions options)
             return pooledBuilder.ToStringAndFree();
         }
 
-        internal static string FormatLiteral(sbyte value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(sbyte value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))
             {
@@ -369,7 +368,7 @@ internal static string FormatLiteral(sbyte value, ObjectDisplayOptions options,
             }
         }
 
-        internal static string FormatLiteral(byte value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(byte value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))
             {
@@ -381,7 +380,7 @@ internal static string FormatLiteral(byte value, ObjectDisplayOptions options, C
             }
         }
 
-        internal static string FormatLiteral(short value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(short value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))
             {
@@ -395,7 +394,7 @@ internal static string FormatLiteral(short value, ObjectDisplayOptions options,
             }
         }
 
-        internal static string FormatLiteral(ushort value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(ushort value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))
             {
@@ -407,7 +406,7 @@ internal static string FormatLiteral(ushort value, ObjectDisplayOptions options,
             }
         }
 
-        internal static string FormatLiteral(int value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(int value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))
             {
@@ -419,7 +418,7 @@ internal static string FormatLiteral(int value, ObjectDisplayOptions options, Cu
             }
         }
 
-        internal static string FormatLiteral(uint value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(uint value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             var pooledBuilder = PooledStringBuilder.GetInstance();
             var sb = pooledBuilder.Builder;
@@ -442,7 +441,7 @@ internal static string FormatLiteral(uint value, ObjectDisplayOptions options, C
             return pooledBuilder.ToStringAndFree();
         }
 
-        internal static string FormatLiteral(long value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(long value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             var pooledBuilder = PooledStringBuilder.GetInstance();
             var sb = pooledBuilder.Builder;
@@ -465,7 +464,7 @@ internal static string FormatLiteral(long value, ObjectDisplayOptions options, C
             return pooledBuilder.ToStringAndFree();
         }
 
-        internal static string FormatLiteral(ulong value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(ulong value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             var pooledBuilder = PooledStringBuilder.GetInstance();
             var sb = pooledBuilder.Builder;
@@ -488,28 +487,28 @@ internal static string FormatLiteral(ulong value, ObjectDisplayOptions options,
             return pooledBuilder.ToStringAndFree();
         }
 
-        internal static string FormatLiteral(double value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(double value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             var result = value.ToString("R", GetFormatCulture(cultureInfo));
 
             return options.IncludesOption(ObjectDisplayOptions.IncludeTypeSuffix) ? result + "D" : result;
         }
 
-        internal static string FormatLiteral(float value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(float value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             var result = value.ToString("R", GetFormatCulture(cultureInfo));
 
             return options.IncludesOption(ObjectDisplayOptions.IncludeTypeSuffix) ? result + "F" : result;
         }
 
-        internal static string FormatLiteral(decimal value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)
+        internal static string FormatLiteral(decimal value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)
         {
             var result = value.ToString(GetFormatCulture(cultureInfo));
 
             return options.IncludesOption(ObjectDisplayOptions.IncludeTypeSuffix) ? result + "M" : result;
         }
 
-        private static CultureInfo GetFormatCulture(CultureInfo cultureInfo)
+        private static CultureInfo GetFormatCulture(CultureInfo? cultureInfo)
         {
             return cultureInfo ?? CultureInfo.InvariantCulture;
         }
diff --git a/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplay.cs b/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplay.cs
@@ -297,7 +297,7 @@ private static ArrayBuilder<SymbolDisplayPart> PopulateDisplayParts(
         /// <see cref="long"/>, <see cref="ulong"/>, <see cref="double"/>, <see cref="float"/>, <see cref="decimal"/>,
         /// and <c>null</c>.
         /// </remarks>
-        public static string FormatPrimitive(object obj, bool quoteStrings, bool useHexadecimalNumbers)
+        public static string? FormatPrimitive(object? obj, bool quoteStrings, bool useHexadecimalNumbers)
         {
             var options = ObjectDisplayOptions.EscapeNonPrintableCharacters;
             if (quoteStrings)
diff --git a/src/Compilers/CSharp/Portable/Symbols/TypedConstantExtensions.cs b/src/Compilers/CSharp/Portable/Symbols/TypedConstantExtensions.cs
@@ -40,7 +40,9 @@ public static string ToCSharpString(this TypedConstant constant)
             }
 
             Debug.Assert(constant.ValueInternal is object);
-            return SymbolDisplay.FormatPrimitive(constant.ValueInternal, quoteStrings: true, useHexadecimalNumbers: false);
+            var result = SymbolDisplay.FormatPrimitive(constant.ValueInternal, quoteStrings: true, useHexadecimalNumbers: false);
+            Debug.Assert(result != null);
+            return result;
         }
 
         // Decode the value of enum constant
diff --git a/src/Compilers/CSharp/Portable/Utilities/ValueSetFactory.CharTC.cs b/src/Compilers/CSharp/Portable/Utilities/ValueSetFactory.CharTC.cs
@@ -50,7 +50,9 @@ char INumericTC<char>.Next(char value)
 
             string INumericTC<char>.ToString(char c)
             {
-                return ObjectDisplay.FormatPrimitive(c, ObjectDisplayOptions.EscapeNonPrintableCharacters | ObjectDisplayOptions.UseQuotes);
+                var result = ObjectDisplay.FormatPrimitive(c, ObjectDisplayOptions.EscapeNonPrintableCharacters | ObjectDisplayOptions.UseQuotes);
+                Debug.Assert(result != null);
+                return result;
             }
 
             char INumericTC<char>.Prev(char value)

Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,8 @@`
`2`	`2`	`// The .NET Foundation licenses this file to you under the MIT license.`
`3`	`3`	`// See the LICENSE file in the project root for more information.`
`4`	`4`
`5`		`-#nullable disable`
`6`		`-`
`7`	`5`	`using System;`
	`6`	`+using System.Diagnostics.CodeAnalysis;`
`8`	`7`	`using System.Globalization;`
`9`	`8`	`using System.Reflection;`
`10`	`9`	`using Microsoft.CodeAnalysis.PooledObjects;`
`@@ -35,7 +34,7 @@ internal static class ObjectDisplay`
`35`	`34`	`/// <see cref="long"/>, <see cref="ulong"/>, <see cref="double"/>, <see cref="float"/>, <see cref="decimal"/>,`
`36`	`35`	`/// and <c>null</c>.`
`37`	`36`	`/// </remarks>`
`38`		`- public static string FormatPrimitive(object obj, ObjectDisplayOptions options)`
	`37`	`+ public static string? FormatPrimitive(object? obj, ObjectDisplayOptions options)`
`39`	`38`	`{`
`40`	`39`	`if (obj == null)`
`41`	`40`	`{`
`@@ -138,7 +137,7 @@ internal static string FormatLiteral(bool value)`
`138`	`137`	`/// Returns true if the character should be replaced and sets`
`139`	`138`	`/// <paramref name="replaceWith"/> to the replacement text.`
`140`	`139`	`/// </summary>`
`141`		`- private static bool TryReplaceChar(char c, out string replaceWith)`
	`140`	`+ private static bool TryReplaceChar(char c, [NotNullWhen(returnValue: true)] out string? replaceWith)`
`142`	`141`	`{`
`143`	`142`	`replaceWith = null;`
`144`	`143`	`switch (c)`
`@@ -332,7 +331,7 @@ internal static string FormatLiteral(char c, ObjectDisplayOptions options)`
`332`	`331`	`builder.Append(quote);`
`333`	`332`	`}`
`334`	`333`
`335`		`- string replaceWith;`
	`334`	`+ string? replaceWith;`
`336`	`335`	`if (escapeNonPrintable && TryReplaceChar(c, out replaceWith))`
`337`	`336`	`{`
`338`	`337`	`builder.Append(replaceWith);`
`@@ -355,7 +354,7 @@ internal static string FormatLiteral(char c, ObjectDisplayOptions options)`
`355`	`354`	`return pooledBuilder.ToStringAndFree();`
`356`	`355`	`}`
`357`	`356`
`358`		`- internal static string FormatLiteral(sbyte value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`357`	`+ internal static string FormatLiteral(sbyte value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`359`	`358`	`{`
`360`	`359`	`if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))`
`361`	`360`	`{`
`@@ -369,7 +368,7 @@ internal static string FormatLiteral(sbyte value, ObjectDisplayOptions options,`
`369`	`368`	`}`
`370`	`369`	`}`
`371`	`370`
`372`		`- internal static string FormatLiteral(byte value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`371`	`+ internal static string FormatLiteral(byte value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`373`	`372`	`{`
`374`	`373`	`if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))`
`375`	`374`	`{`
`@@ -381,7 +380,7 @@ internal static string FormatLiteral(byte value, ObjectDisplayOptions options, C`
`381`	`380`	`}`
`382`	`381`	`}`
`383`	`382`
`384`		`- internal static string FormatLiteral(short value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`383`	`+ internal static string FormatLiteral(short value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`385`	`384`	`{`
`386`	`385`	`if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))`
`387`	`386`	`{`
`@@ -395,7 +394,7 @@ internal static string FormatLiteral(short value, ObjectDisplayOptions options,`
`395`	`394`	`}`
`396`	`395`	`}`
`397`	`396`
`398`		`- internal static string FormatLiteral(ushort value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`397`	`+ internal static string FormatLiteral(ushort value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`399`	`398`	`{`
`400`	`399`	`if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))`
`401`	`400`	`{`
`@@ -407,7 +406,7 @@ internal static string FormatLiteral(ushort value, ObjectDisplayOptions options,`
`407`	`406`	`}`
`408`	`407`	`}`
`409`	`408`
`410`		`- internal static string FormatLiteral(int value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`409`	`+ internal static string FormatLiteral(int value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`411`	`410`	`{`
`412`	`411`	`if (options.IncludesOption(ObjectDisplayOptions.UseHexadecimalNumbers))`
`413`	`412`	`{`
`@@ -419,7 +418,7 @@ internal static string FormatLiteral(int value, ObjectDisplayOptions options, Cu`
`419`	`418`	`}`
`420`	`419`	`}`
`421`	`420`
`422`		`- internal static string FormatLiteral(uint value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`421`	`+ internal static string FormatLiteral(uint value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`423`	`422`	`{`
`424`	`423`	`var pooledBuilder = PooledStringBuilder.GetInstance();`
`425`	`424`	`var sb = pooledBuilder.Builder;`
`@@ -442,7 +441,7 @@ internal static string FormatLiteral(uint value, ObjectDisplayOptions options, C`
`442`	`441`	`return pooledBuilder.ToStringAndFree();`
`443`	`442`	`}`
`444`	`443`
`445`		`- internal static string FormatLiteral(long value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`444`	`+ internal static string FormatLiteral(long value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`446`	`445`	`{`
`447`	`446`	`var pooledBuilder = PooledStringBuilder.GetInstance();`
`448`	`447`	`var sb = pooledBuilder.Builder;`
`@@ -465,7 +464,7 @@ internal static string FormatLiteral(long value, ObjectDisplayOptions options, C`
`465`	`464`	`return pooledBuilder.ToStringAndFree();`
`466`	`465`	`}`
`467`	`466`
`468`		`- internal static string FormatLiteral(ulong value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`467`	`+ internal static string FormatLiteral(ulong value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`469`	`468`	`{`
`470`	`469`	`var pooledBuilder = PooledStringBuilder.GetInstance();`
`471`	`470`	`var sb = pooledBuilder.Builder;`
`@@ -488,28 +487,28 @@ internal static string FormatLiteral(ulong value, ObjectDisplayOptions options,`
`488`	`487`	`return pooledBuilder.ToStringAndFree();`
`489`	`488`	`}`
`490`	`489`
`491`		`- internal static string FormatLiteral(double value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`490`	`+ internal static string FormatLiteral(double value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`492`	`491`	`{`
`493`	`492`	`var result = value.ToString("R", GetFormatCulture(cultureInfo));`
`494`	`493`
`495`	`494`	`return options.IncludesOption(ObjectDisplayOptions.IncludeTypeSuffix) ? result + "D" : result;`
`496`	`495`	`}`
`497`	`496`
`498`		`- internal static string FormatLiteral(float value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`497`	`+ internal static string FormatLiteral(float value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`499`	`498`	`{`
`500`	`499`	`var result = value.ToString("R", GetFormatCulture(cultureInfo));`
`501`	`500`
`502`	`501`	`return options.IncludesOption(ObjectDisplayOptions.IncludeTypeSuffix) ? result + "F" : result;`
`503`	`502`	`}`
`504`	`503`
`505`		`- internal static string FormatLiteral(decimal value, ObjectDisplayOptions options, CultureInfo cultureInfo = null)`
	`504`	`+ internal static string FormatLiteral(decimal value, ObjectDisplayOptions options, CultureInfo? cultureInfo = null)`
`506`	`505`	`{`
`507`	`506`	`var result = value.ToString(GetFormatCulture(cultureInfo));`
`508`	`507`
`509`	`508`	`return options.IncludesOption(ObjectDisplayOptions.IncludeTypeSuffix) ? result + "M" : result;`
`510`	`509`	`}`
`511`	`510`
`512`		`- private static CultureInfo GetFormatCulture(CultureInfo cultureInfo)`
	`511`	`+ private static CultureInfo GetFormatCulture(CultureInfo? cultureInfo)`
`513`	`512`	`{`
`514`	`513`	`return cultureInfo ?? CultureInfo.InvariantCulture;`
`515`	`514`	`}`
Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,7 @@ private static ArrayBuilder<SymbolDisplayPart> PopulateDisplayParts(`
`297`	`297`	`/// <see cref="long"/>, <see cref="ulong"/>, <see cref="double"/>, <see cref="float"/>, <see cref="decimal"/>,`
`298`	`298`	`/// and <c>null</c>.`
`299`	`299`	`/// </remarks>`
`300`		`- public static string FormatPrimitive(object obj, bool quoteStrings, bool useHexadecimalNumbers)`
	`300`	`+ public static string? FormatPrimitive(object? obj, bool quoteStrings, bool useHexadecimalNumbers)`
`301`	`301`	`{`
`302`	`302`	`var options = ObjectDisplayOptions.EscapeNonPrintableCharacters;`
`303`	`303`	`if (quoteStrings)`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,9 @@ public static string ToCSharpString(this TypedConstant constant)`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`Debug.Assert(constant.ValueInternal is object);`
`43`		`- return SymbolDisplay.FormatPrimitive(constant.ValueInternal, quoteStrings: true, useHexadecimalNumbers: false);`
	`43`	`+ var result = SymbolDisplay.FormatPrimitive(constant.ValueInternal, quoteStrings: true, useHexadecimalNumbers: false);`
	`44`	`+ Debug.Assert(result != null);`
	`45`	`+ return result;`
`44`	`46`	`}`
`45`	`47`
`46`	`48`	`// Decode the value of enum constant`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,9 @@ char INumericTC<char>.Next(char value)`
`50`	`50`
`51`	`51`	`string INumericTC<char>.ToString(char c)`
`52`	`52`	`{`
`53`		`- return ObjectDisplay.FormatPrimitive(c, ObjectDisplayOptions.EscapeNonPrintableCharacters \| ObjectDisplayOptions.UseQuotes);`
	`53`	`+ var result = ObjectDisplay.FormatPrimitive(c, ObjectDisplayOptions.EscapeNonPrintableCharacters \| ObjectDisplayOptions.UseQuotes);`
	`54`	`+ Debug.Assert(result != null);`
	`55`	`+ return result;`
`54`	`56`	`}`
`55`	`57`
`56`	`58`	`char INumericTC<char>.Prev(char value)`