Skip to content

Commit b473bc7

Browse files
author
Julien Couvreur
committed
Use dedicated link (78968) for follow-ups on functionality gaps
1 parent 6674ec8 commit b473bc7

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13869,7 +13869,7 @@ static class E
1386913869
}
1387013870
}
1387113871
""";
13872-
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
13872+
// Tracked by https://github.com/dotnet/roslyn/issues/78968 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
1387313873
var comp = CreateCompilation(source, options: TestOptions.ReleaseDll);
1387413874
comp.VerifyEmitDiagnostics(
1387513875
//// (5,9): error CS9106: Identifier 'Color' is ambiguous between type 'Color' and parameter 'Color Color' in this context.
@@ -13912,7 +13912,7 @@ static class E2
1391213912
}
1391313913
}
1391413914
""";
13915-
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
13915+
// Tracked by https://github.com/dotnet/roslyn/issues/78968 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
1391613916
var comp = CreateCompilation(source, options: TestOptions.ReleaseDll);
1391713917
comp.VerifyEmitDiagnostics(
1391813918
//// (5,9): error CS9106: Identifier 'Color' is ambiguous between type 'Color' and parameter 'Color Color' in this context.
@@ -16642,7 +16642,7 @@ public class C
1664216642
Diagnostic(ErrorCode.ERR_BadDynamicQuery, "where i is not null").WithLocation(2, 9));
1664316643
}
1664416644

16645-
[Fact(Skip = "Tracked by https://github.com/dotnet/roslyn/issues/76130 : WasPropertyBackingFieldAccessChecked asserts that we're setting twice")]
16645+
[Fact(Skip = "Tracked by https://github.com/dotnet/roslyn/issues/78968 : WasPropertyBackingFieldAccessChecked asserts that we're setting twice")]
1664616646
public void ResolveAll_Query_Cast()
1664716647
{
1664816648
var source = """
@@ -19165,7 +19165,7 @@ public static void M1<T>(T x) where T : unmanaged
1916519165
}
1916619166
}
1916719167
""";
19168-
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
19168+
// Tracked by https://github.com/dotnet/roslyn/issues/78968 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
1916919169
var comp = CreateCompilation(source, options: TestOptions.ReleaseDll);
1917019170
comp.VerifyEmitDiagnostics(
1917119171
//// (5,9): error CS9106: Identifier 'Color' is ambiguous between type 'Color' and parameter 'Color Color' in this context.
@@ -19211,7 +19211,7 @@ static class E2
1921119211
}
1921219212
}
1921319213
""";
19214-
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
19214+
// Tracked by https://github.com/dotnet/roslyn/issues/78968 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
1921519215
var comp = CreateCompilation(source, options: TestOptions.ReleaseDll);
1921619216
comp.VerifyEmitDiagnostics();
1921719217

@@ -19254,7 +19254,7 @@ public static void M1<T>(T x) where T : unmanaged
1925419254
}
1925519255
}
1925619256
""";
19257-
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
19257+
// Tracked by https://github.com/dotnet/roslyn/issues/78968 : missing ERR_AmbiguousPrimaryConstructorParameterAsColorColorReceiver
1925819258
var comp = CreateCompilation(source, options: TestOptions.ReleaseDll);
1925919259
comp.VerifyEmitDiagnostics(
1926019260
//// (5,9): error CS9106: Identifier 'Color' is ambiguous between type 'Color' and parameter 'Color Color' in this context.
@@ -33375,7 +33375,7 @@ static class E
3337533375

3337633376
public partial class RegionAnalysisTests : FlowTestBase
3337733377
{
33378-
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : consider removing `this` from the region analysis tests
33378+
// Tracked by https://github.com/dotnet/roslyn/issues/78968 : consider removing `this` from the region analysis tests
3337933379
[Fact]
3338033380
public void RegionAnalysis_01()
3338133381
{
@@ -36702,7 +36702,7 @@ static class E
3670236702

3670336703
Assert.Equal("<>E__0", comp.GetTypeByMetadataName("E").GetTypeMembers().Single().ExtensionName);
3670436704

36705-
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : we should find the unspeakable nested type
36705+
// Tracked by https://github.com/dotnet/roslyn/issues/78968 : we should find the unspeakable nested type
3670636706
Assert.Null(comp.GetTypeByMetadataName("E+<>E__0"));
3670736707
}
3670836708

@@ -39654,7 +39654,7 @@ class C
3965439654
public object? P => null;
3965539655
}
3965639656
""";
39657-
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : we shouldn't care about static/instance mismatch in nameof
39657+
// Tracked by https://github.com/dotnet/roslyn/issues/78968 : should disallow usage of extension members in nameof
3965839658
comp = CreateCompilation(src, targetFramework: TargetFramework.Net90);
3965939659
comp.VerifyEmitDiagnostics(
3966039660
// (5,5): warning CS8602: Dereference of a possibly null reference.

src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests2.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ public static class E
597597
public static void M2<T>(this T t) { System.Console.Write("method2 "); }
598598
}
599599
""";
600-
// Tracked by https://github.com/dotnet/roslyn/issues/76130 : should work
600+
// Tracked by https://github.com/dotnet/roslyn/issues/78968 : known bug, should work
601601
var comp = CreateCompilation(src);
602602
comp.VerifyEmitDiagnostics(
603603
// (4,12): error CS1061: '<anonymous type: string Name, int Age>' does not contain a definition for 'P' and no accessible extension method 'P' accepting a first argument of type '<anonymous type: string Name, int Age>' could be found (are you missing a using directive or an assembly reference?)

0 commit comments

Comments
 (0)