Skip to content

Commit ba38051

Browse files
Delete the old Intellisense option pages
These were ported to Unified Settings, and since that's now the default (and no way to go back), there's no reason to keep the legacy ones around. I've verified the new pages still have the same contents of the old ones.
1 parent b8eec28 commit ba38051

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+4
-1051
lines changed

src/VisualStudio/CSharp/Impl/CSharpPackage.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ namespace Microsoft.VisualStudio.LanguageServices.CSharp.LanguageService;
3939
// Spacing
4040
// Wrapping
4141
// Naming
42-
// IntelliSense
4342

4443
[ProvideLanguageEditorOptionPage(typeof(Options.AdvancedOptionPage), "CSharp", null, "Advanced", pageNameResourceId: "#102", keywordListResourceId: 306)]
4544
[ProvideLanguageEditorToolsOptionCategory("CSharp", "Code Style", "#114")]
@@ -51,7 +50,6 @@ namespace Microsoft.VisualStudio.LanguageServices.CSharp.LanguageService;
5150
[ProvideLanguageEditorOptionPage(typeof(Options.Formatting.FormattingNewLinesPage), "CSharp", @"Code Style\Formatting", "NewLines", pageNameResourceId: "#111", keywordListResourceId: 309)]
5251
[ProvideLanguageEditorOptionPage(typeof(Options.Formatting.FormattingSpacingPage), "CSharp", @"Code Style\Formatting", "Spacing", pageNameResourceId: "#112", keywordListResourceId: 310)]
5352
[ProvideLanguageEditorOptionPage(typeof(Options.NamingStylesOptionPage), "CSharp", @"Code Style", "Naming", pageNameResourceId: "#115", keywordListResourceId: 314)]
54-
[ProvideLanguageEditorOptionPage(typeof(Options.IntelliSenseOptionPage), "CSharp", null, "IntelliSense", pageNameResourceId: "#103", keywordListResourceId: 312)]
5553
[ProvideSettingsManifest(PackageRelativeManifestFile = @"UnifiedSettings\csharpSettings.registration.json")]
5654
[ProvideService(typeof(ICSharpTempPECompilerService), IsAsyncQueryable = false, IsCacheable = true, IsFreeThreaded = true, ServiceName = "C# TempPE Compiler Service")]
5755
[Guid(Guids.CSharpPackageIdString)]

src/VisualStudio/CSharp/Impl/Options/IntelliSenseOptionPage.cs

Lines changed: 0 additions & 18 deletions
This file was deleted.

src/VisualStudio/CSharp/Impl/Options/IntelliSenseOptionPageControl.xaml

Lines changed: 0 additions & 88 deletions
This file was deleted.

src/VisualStudio/CSharp/Impl/Options/IntelliSenseOptionPageControl.xaml.cs

Lines changed: 0 additions & 75 deletions
This file was deleted.

src/VisualStudio/CSharp/Impl/Options/IntelliSenseOptionPageStrings.cs

Lines changed: 0 additions & 83 deletions
This file was deleted.

src/VisualStudio/CSharp/Impl/PackageRegistration.pkgdef

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,6 @@
125125
"Page"="{eae577a7-acb9-40f5-a7b1-d2878c3c7d6f}"
126126
"Keywords"="#313"
127127

128-
[$RootKey$\Languages\Language Services\CSharp\EditorToolsOptions\IntelliSense]
129-
@="#103"
130-
"Package"="{13c3bbb4-f18f-4111-9f54-a0fb010d9194}"
131-
"Page"="{ede66829-7a36-4c5d-8e20-9290195dcf80}"
132-
"Keywords"="#312"
133-
134128
[$RootKey$\Languages\Language Services\CSharp\EditorToolsOptions\Code Style\Formatting]
135129
@="#107"
136130
"Package"="{13c3bbb4-f18f-4111-9f54-a0fb010d9194}"
@@ -200,4 +194,4 @@
200194
[$RootKey$\SettingsManifests\{13c3bbb4-f18f-4111-9f54-a0fb010d9194}]
201195
@="Microsoft.VisualStudio.LanguageServices.CSharp.LanguageService.CSharpPackage"
202196
"ManifestPath"="$PackageFolder$\UnifiedSettings\csharpSettings.registration.json"
203-
"CacheTag"=qword:18C11F0A543B8AD0
197+
"CacheTag"=qword:2775F6D5BE71E0F1

src/VisualStudio/CSharp/Impl/UnifiedSettings/csharpSettings.registration.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,7 @@
254254
"title": "@101;{13c3bbb4-f18f-4111-9f54-a0fb010d9194}"
255255
},
256256
"textEditor.csharp.intellisense": {
257-
"title": "@103;{13c3bbb4-f18f-4111-9f54-a0fb010d9194}",
258-
"legacyOptionPageId": "EDE66829-7A36-4c5d-8E20-9290195DCF80"
257+
"title": "@103;{13c3bbb4-f18f-4111-9f54-a0fb010d9194}"
259258
}
260259
}
261260
}

src/VisualStudio/CSharp/Impl/VSPackage.resx

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -283,26 +283,6 @@ Insert space before and after binary operators;</value>
283283
<value>Change formatting options for wrapping;leave block on single line;leave statements and member declarations on the same line</value>
284284
<comment>C# Formatting &gt; Wrapping options page keywords</comment>
285285
</data>
286-
<data name="312" xml:space="preserve">
287-
<value>Change completion list settings;Pre-select most recently used member; Completion Lists;
288-
Show completion list after a character is typed;
289-
Show completion list after a character is deleted;
290-
Automatically show completion list in argument lists (experimental);
291-
Highlight matching portions of completion list items;
292-
Show completion item filters;
293-
Automatically complete statement on semicolon;
294-
Snippets behavior;
295-
Never include snippets;
296-
Always include snippets;
297-
Include snippets when ?-Tab is typed after an identifier;
298-
Enter key behavior;
299-
Never add new line on enter;
300-
Only add new line on enter after end of fully typed word;
301-
Always add new line on enter;
302-
Show name suggestions;
303-
Show items from unimported namespaces (experimental);</value>
304-
<comment>C# IntelliSense options page keywords</comment>
305-
</data>
306286
<data name="107" xml:space="preserve">
307287
<value>Formatting</value>
308288
<comment>"Formatting" category node under Tools &gt; Options, Text Editor, C#, Code Style (no corresponding keywords)</comment>

0 commit comments

Comments
 (0)