Skip to content

Commit bdf23fd

Browse files
author
Julien Couvreur
authored
Document more steps in our C# release process (#78539)
1 parent 0927e41 commit bdf23fd

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1726,10 +1726,12 @@ public void LangVersion_LangVersions()
17261726
public void LanguageVersionAdded_Canary()
17271727
{
17281728
// When a new version is added, this test will break. This list must be checked:
1729-
// - update the "UpgradeProject" codefixer
1730-
// - update all the tests that call this canary
1731-
// - update _MaxAvailableLangVersion (a relevant test should break when new version is introduced)
1732-
// - email release management to add to the release notes (see csharp-version in release.json in previous example: https://github.com/dotnet/core/pull/9493)
1729+
// 1. update the "UpgradeProject" codefixer
1730+
// 2. update all the tests that call this canary
1731+
// 3. update _MaxAvailableLangVersion (a relevant test should break when new version is introduced)
1732+
// 4. email release management to add to the release notes (see csharp-version in release.json in previous example: https://github.com/dotnet/core/pull/9493)
1733+
// 5. make csharplang updates documented at https://github.com/dotnet/csharplang/blob/main/Design-Process.md#steps-to-move-a-triaged-feature-to-an-implemented-feature
1734+
// 6. push the list of specs to Codex. See previous example: https://devdiv.visualstudio.com/OnlineServices/_git/CodexV2Data/pullrequest/618779
17331735
AssertEx.SetEqual(new[] { "default", "1", "2", "3", "4", "5", "6", "7.0", "7.1", "7.2", "7.3", "8.0", "9.0", "10.0", "11.0", "12.0", "13.0", "latest", "latestmajor", "preview" },
17341736
Enum.GetValues(typeof(LanguageVersion)).Cast<LanguageVersion>().Select(v => v.ToDisplayString()));
17351737
// For minor versions and new major versions, the format should be "x.y", such as "7.1"
@@ -10039,7 +10041,7 @@ public class Program
1003910041
var outWriter = new StringWriter(CultureInfo.InvariantCulture);
1004010042
int exitCode = compiler.Run(outWriter);
1004110043
return (exitCode, outWriter.ToString());
10042-
};
10044+
}
1004310045
}
1004410046

1004510047
// See also NullableContextTests.NullableAnalysisFlags_01().
@@ -10081,7 +10083,7 @@ string[] compileAndRun(string featureOpt)
1008110083
var outWriter = new StringWriter(CultureInfo.InvariantCulture);
1008210084
int exitCode = compiler.Run(outWriter);
1008310085
return outWriter.ToString().Split(new[] { '\n', '\r' }, StringSplitOptions.RemoveEmptyEntries);
10084-
};
10086+
}
1008510087
}
1008610088

1008710089
[Fact]

0 commit comments

Comments
 (0)