Merge pull request #56121 from dotnet/merges/main-to-main-vs-deps

Merge main to main-vs-deps

Author: dotnet-bot

src/Compilers/CSharp/Portable/CSharpResources.resx

@@ -6857,4 +6857,7 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
   <data name="WRN_InterpolatedStringHandlerArgumentAttributeIgnoredOnLambdaParameters_Title" xml:space="preserve">
     <value>InterpolatedStringHandlerArgument has no effect when applied to lambda parameters and will be ignored at the call site.</value>
   </data>
+  <data name="ERR_LambdaWithAttributesToExpressionTree" xml:space="preserve">
+    <value>A lambda expression with attributes cannot be converted to an expression tree</value>
+  </data>
 </root>

src/Compilers/CSharp/Portable/Errors/ErrorCode.cs

@@ -1995,6 +1995,7 @@ internal enum ErrorCode
         // WRN_AttrDependentTypeNotAllowed = 8969, // Backed out of of warning wave 6, may be reintroduced later
         ERR_AttrDependentTypeNotAllowed = 8970,
         WRN_InterpolatedStringHandlerArgumentAttributeIgnoredOnLambdaParameters = 8971,
+        ERR_LambdaWithAttributesToExpressionTree = 8972,
 
         #endregion
 

src/Compilers/CSharp/Portable/Lowering/DiagnosticsPass_ExpressionTrees.cs

@@ -517,6 +517,14 @@ public override BoundNode VisitLambda(BoundLambda node)
             if (_inExpressionLambda)
             {
                 var lambda = node.Symbol;
+                bool reportedAttributes = false;
+
+                if (!lambda.GetAttributes().IsEmpty || !lambda.GetReturnTypeAttributes().IsEmpty)
+                {
+                    Error(ErrorCode.ERR_LambdaWithAttributesToExpressionTree, node);
+                    reportedAttributes = true;
+                }
+
                 foreach (var p in lambda.Parameters)
                 {
                     if (p.RefKind != RefKind.None && p.Locations.Length != 0)
@@ -527,6 +535,12 @@ public override BoundNode VisitLambda(BoundLambda node)
                     {
                         _diagnostics.Add(ErrorCode.ERR_ExpressionTreeCantContainRefStruct, p.Locations[0], p.Type.Name);
                     }
+
+                    if (!reportedAttributes && !p.GetAttributes().IsEmpty)
+                    {
+                        _diagnostics.Add(ErrorCode.ERR_LambdaWithAttributesToExpressionTree, p.Locations[0]);
+                        reportedAttributes = true;
+                    }
                 }
 
                 switch (node.Syntax.Kind())

src/Compilers/CSharp/Portable/Symbols/NativeIntegerTypeSymbol.cs

@@ -70,7 +70,6 @@ public override ImmutableArray<Symbol> GetMembers()
             ImmutableArray<Symbol> makeMembers(ImmutableArray<Symbol> underlyingMembers)
             {
                 var builder = ArrayBuilder<Symbol>.GetInstance();
-                builder.Add(new SynthesizedInstanceConstructor(this));
                 foreach (var underlyingMember in underlyingMembers)
                 {
                     Debug.Assert(_underlyingType.Equals(underlyingMember.ContainingSymbol));
@@ -103,6 +102,13 @@ ImmutableArray<Symbol> makeMembers(ImmutableArray<Symbol> underlyingMembers)
                                             break;
                                     }
                                     break;
+
+                                case MethodKind.Constructor:
+                                    if (underlyingMethod.ParameterCount == 0)
+                                    {
+                                        builder.Add(new NativeIntegerMethodSymbol(this, underlyingMethod, associatedSymbol: null));
+                                    }
+                                    break;
                             }
                             break;
                         case PropertySymbol underlyingProperty: