Fix

Author: tmat

src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverTests.cs

@@ -1500,7 +1500,7 @@ [Attr] class C { }
             {
                 var name = ctx.ForAttributeWithSimpleName<ClassDeclarationSyntax>("Attr")
                     .Select((c, _) => c.Identifier.ValueText)
-                    .WithComparer(new LambdaComparer<string>((_, _) => throw e));
+                    .WithComparer(EqualityComparer<string>.Create((_, _) => throw e));
                 ctx.RegisterSourceOutput(name, (spc, n) => spc.AddSource(n, "// generated"));
             });
 
@@ -1997,7 +1997,7 @@ class C { }
 
             var generator = new IncrementalGeneratorWrapper(new PipelineCallbackGenerator(ctx =>
             {
-                var compilationSource = ctx.CompilationProvider.WithComparer(new LambdaComparer<Compilation>((c1, c2) => true, 0));
+                var compilationSource = ctx.CompilationProvider.WithComparer(EqualityComparer<Compilation>.Create((_, _) => true, _ => 0));
                 ctx.RegisterSourceOutput(compilationSource, (spc, c) =>
                 {
                     compilationsCalledFor.Add(c);
@@ -2035,7 +2035,7 @@ class C { }
             {
                 var compilationSource = ctx.CompilationProvider.Combine(ctx.AdditionalTextsProvider.Collect())
                                                 // comparer that ignores the LHS (additional texts)
-                                                .WithComparer(new LambdaComparer<(Compilation, ImmutableArray<AdditionalText>)>((c1, c2) => c1.Item1 == c2.Item1, 0))
+                                                .WithComparer(EqualityComparer<(Compilation, ImmutableArray<AdditionalText>)>.Create((c1, c2) => c1.Item1 == c2.Item1, _ => 0))
                                                 .WithTrackingName("Step")
                                                 .Select((x, ct) => x)
                                                 .WithTrackingName("Step2");

src/Compilers/CSharp/Test/Semantic/SourceGeneration/StateTableTests.cs

@@ -233,7 +233,7 @@ public void Node_Table_Caches_Previous_Object_When_Modification_Considered_Cache
             var expected = ImmutableArray.Create((1, EntryState.Added, 0), (2, EntryState.Added, 0), (3, EntryState.Added, 0));
             AssertTableEntries(previousTable, expected);
 
-            builder = previousTable.ToBuilder(stepName: null, false, new LambdaComparer<int>((i, j) => i == 3 || i == j));
+            builder = previousTable.ToBuilder(stepName: null, false, EqualityComparer<int>.Create((i, j) => i == 3 || i == j));
             Assert.True(builder.TryModifyEntry(1, TimeSpan.Zero, default, EntryState.Modified)); // ((1, EntryState.Cached))
             Assert.True(builder.TryModifyEntry(4, TimeSpan.Zero, default, EntryState.Modified)); // ((4, EntryState.Modified))
             Assert.True(builder.TryModifyEntry(5, TimeSpan.Zero, default, EntryState.Modified)); // ((3, EntryState.Cached))
@@ -918,7 +918,7 @@ public void CombineNode_Records_Removed_Outputs_Of_Removed_First_Input()
         public void User_Comparer_Is_Not_Used_To_Determine_Inputs()
         {
             var inputNode = new InputNode<int>((_) => ImmutableArray.Create(1, 2, 3))
-                                .WithComparer(new LambdaComparer<int>((a, b) => false));
+                                .WithComparer(EqualityComparer<int>.Create((_, _) => false));
 
             // first time through will always be added (because it's not been run before)
             DriverStateTable.Builder dstBuilder = GetBuilder(DriverStateTable.Empty);

src/Compilers/CSharp/Test/Semantic/SourceGeneration/SyntaxAwareGeneratorTests.cs

@@ -1513,7 +1513,7 @@ class C
             var testGenerator = new PipelineCallbackGenerator(context =>
             {
                 var source = context.SyntaxProvider.CreateSyntaxProvider((c, _) => c is FieldDeclarationSyntax fds, (c, _) => ((FieldDeclarationSyntax)c.Node).Declaration.Variables[0].Identifier.ValueText);
-                source = source.WithComparer(new LambdaComparer<string>((a, b) => true)).WithTrackingName("Fields");
+                source = source.WithComparer(EqualityComparer<string>.Create((a, b) => true)).WithTrackingName("Fields");
                 context.RegisterSourceOutput(source, (spc, fieldName) =>
                 {
                 });
@@ -1574,10 +1574,10 @@ class C
                     syntaxCalledFor.Add(((FieldDeclarationSyntax)c.Node).Declaration.Variables[0].Identifier.ValueText);
                     return ((FieldDeclarationSyntax)c.Node).Declaration.Variables[0].Identifier.ValueText;
                 });
-                source = source.WithComparer(new LambdaComparer<string>((a, b) => false));
-                source = source.WithComparer(new LambdaComparer<string>((a, b) => false));
-                source = source.WithComparer(new LambdaComparer<string>((a, b) => false));
-                source = source.WithComparer(new LambdaComparer<string>((a, b) => false));
+                source = source.WithComparer(EqualityComparer<string>.Create((a, b) => false));
+                source = source.WithComparer(EqualityComparer<string>.Create((a, b) => false));
+                source = source.WithComparer(EqualityComparer<string>.Create((a, b) => false));
+                source = source.WithComparer(EqualityComparer<string>.Create((a, b) => false));
                 context.RegisterSourceOutput(source, (spc, fieldName) => { });
             });
 
@@ -1631,7 +1631,7 @@ class C
                     noCompareCalledFor.Add(fieldName);
                 });
 
-                var comparerSource = source.WithComparer(new LambdaComparer<string>((a, b) => true));
+                var comparerSource = source.WithComparer(EqualityComparer<string>.Create((a, b) => true));
                 context.RegisterSourceOutput(comparerSource, (spc, fieldName) =>
                 {
                     compareCalledFor.Add(fieldName);
@@ -1794,7 +1794,7 @@ class C
                     return ((FieldDeclarationSyntax)c.Node).Declaration.Variables[0].Identifier.ValueText;
                 }).WithTrackingName("Fields");
 
-                var comparerSource = source.WithComparer(new LambdaComparer<string>((a, b) => false));
+                var comparerSource = source.WithComparer(EqualityComparer<string>.Create((a, b) => false));
 
                 // now join the two sources together
                 var joinedSource = source.Combine(comparerSource.Collect());

src/Compilers/Core/CodeAnalysisTest/Text/TextChangeTests.cs

@@ -280,7 +280,7 @@ private static void AssertChangedTextLinesHelper(string originalText, params Tex
             var changedText = SourceText.From(originalText).WithChanges(changes);
             var comparer = EqualityComparer<TextLine>.Create((x, y) => x.Span == y.Span, x => x.Span.GetHashCode());
 
-            Assert.Equal(SourceText.From(changedText.ToString()).Lines, changedText.Lines, new TextLineEqualityComparer());
+            Assert.Equal(SourceText.From(changedText.ToString()).Lines, changedText.Lines, comparer);
         }
 
         [Fact]