Skip to content

Commit dfd0a2a

Browse files
Turn off ngen for Microsoft.CodeAnalysis.Workspaces.MSBuild
The number of users this could help is very, very tiny, and the number of ways it could cause further problems is much, much higher.
1 parent 4085cc0 commit dfd0a2a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/VisualStudio/Setup/Roslyn.VisualStudio.Setup.csproj

+6
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,12 @@
173173
<ForceIncludeInVSIX>true</ForceIncludeInVSIX>
174174
<AdditionalProperties>TargetFramework=net472</AdditionalProperties>
175175
<PkgDefEntry>BindingRedirect</PkgDefEntry>
176+
177+
<!-- Disable ngen. If we don't set this, ngen is enabled for all binaries coming from this ProjectReference, which includes the build hosts coming in as content.
178+
That doesn't make sense to do for the .NET Core build host (since ngen isn't supported there), and without extra configuation to specify the correct set
179+
of binding redirects, it probably won't be useful for the .NET Framework one in practice. Customer use of MSBuildWorkspace inside Visual Studio is rare as it is;
180+
so while we could try to do a bunch of extra MSBuild trickery to get the right ngen attributes to the right binaries, it's just far easier to turn it off. -->
181+
<Ngen>false</Ngen>
176182
</ProjectReference>
177183
<ProjectReference Include="..\..\Workspaces\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.Workspaces.csproj">
178184
<Name>CSharpWorkspace</Name>

0 commit comments

Comments
 (0)