feedback

Author: dibarbet

src/EditorFeatures/Core/Implementation/LanguageServer/VisualStudioLspWorkspaceRegistrationEventListener.cs renamed to src/EditorFeatures/Core/Implementation/LanguageServer/LspWorkspaceRegistrationEventListener.cs

@@ -11,13 +11,13 @@
 namespace Microsoft.CodeAnalysis.Editor.Implementation.LanguageClient
 {
     [ExportEventListener(WellKnownEventListeners.Workspace, WorkspaceKind.Host, WorkspaceKind.MiscellaneousFiles, WorkspaceKind.MetadataAsSource), Shared]
-    internal class VisualStudioLspWorkspaceRegistrationEventListener : IEventListener<object>
+    internal class LspWorkspaceRegistrationEventListener : IEventListener<object>
     {
         private readonly ILspWorkspaceRegistrationService _lspWorkspaceRegistrationService;
 
         [ImportingConstructor]
         [Obsolete(MefConstruction.ImportingConstructorMessage, error: true)]
-        public VisualStudioLspWorkspaceRegistrationEventListener(ILspWorkspaceRegistrationService lspWorkspaceRegistrationService)
+        public LspWorkspaceRegistrationEventListener(ILspWorkspaceRegistrationService lspWorkspaceRegistrationService)
         {
             _lspWorkspaceRegistrationService = lspWorkspaceRegistrationService;
         }

src/EditorFeatures/Core/Implementation/LanguageServer/VisualStudioLspWorkspaceRegistrationService.cs renamed to src/EditorFeatures/Core/Implementation/LanguageServer/LspWorkspaceRegistrationService.cs

@@ -13,14 +13,14 @@
 namespace Microsoft.CodeAnalysis.Editor.Implementation.LanguageClient
 {
     [Export(typeof(ILspWorkspaceRegistrationService)), Shared]
-    internal class VisualStudioLspWorkspaceRegistrationService : ILspWorkspaceRegistrationService
+    internal class LspWorkspaceRegistrationService : ILspWorkspaceRegistrationService
     {
         private readonly object _gate = new();
         private ImmutableArray<Workspace> _registrations = ImmutableArray.Create<Workspace>();
 
         [ImportingConstructor]
         [Obsolete(MefConstruction.ImportingConstructorMessage, error: true)]
-        public VisualStudioLspWorkspaceRegistrationService()
+        public LspWorkspaceRegistrationService()
         {
         }
 

src/Features/Lsif/Generator/Microsoft.CodeAnalysis.LanguageServerIndexFormat.Generator.csproj

@@ -54,6 +54,8 @@
   </ItemGroup>
 
   <ItemGroup>
+    <!-- Reference to EditorFeatures should be removed once Hover is moved into the Features layer.
+         See https://github.com/dotnet/roslyn/issues/55142 for details -->
     <ProjectReference Include="..\..\..\EditorFeatures\Core\Microsoft.CodeAnalysis.EditorFeatures.csproj" />
     <ProjectReference Include="..\..\..\Workspaces\Core\MSBuild\Microsoft.CodeAnalysis.Workspaces.MSBuild.csproj" />
     <ProjectReference Include="..\..\..\Workspaces\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.Workspaces.csproj" />