Skip to content

Commit e7629a6

Browse files
Fix auth issue in PR val builds (#79873)
Co-authored-by: David Barbet <dabarbet@microsoft.com>
1 parent 22348b2 commit e7629a6

File tree

1 file changed

+19
-22
lines changed

1 file changed

+19
-22
lines changed

azure-pipelines-pr-validation.yml

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -162,28 +162,6 @@ extends:
162162
displayName: Setting SourceBranchName variable
163163
condition: succeeded()
164164

165-
- task: Powershell@2
166-
name: FancyBuild
167-
displayName: Setting FancyBuild.BuildNumber
168-
inputs:
169-
targetType: inline
170-
script: |
171-
$pull_request = Invoke-RestMethod -Uri "https://api.github.com/repos/dotnet/roslyn/pulls/${{ parameters.PRNumber }}" `
172-
-Headers @{
173-
"Accept" = "application/vnd.github+json";
174-
"X-GitHub-Api-Version" = "2022-11-28"
175-
}
176-
$buildNumberName = "$(OriginalBuildNumber) - $($pull_request.user.login) - '$($pull_request.title)'"
177-
$buildNumberName = $buildNumberName -replace '["/:<>\|?@*]','_'
178-
# Maximum buildnumber length is 255 chars and we are going to append to the end to ensure we have space.
179-
if ($buildNumberName.Length -GT 253) {
180-
$buildNumberName = $buildNumberName.Substring(0, 253)
181-
}
182-
# Avoid ever ending the BuildNumber with a `.` by always appending to it.
183-
$buildNumberName += ' #'
184-
Write-Host "##vso[task.setvariable variable=BuildNumber;isoutput=true;isreadonly=true]$buildNumberName"
185-
Write-Host "##vso[build.updatebuildnumber]$buildNumberName"
186-
187165
- task: Powershell@2
188166
displayName: Tag PR validation build
189167
inputs:
@@ -201,6 +179,25 @@ extends:
201179
arguments: "-sourceBranchName $(SourceBranchName) -prNumber ${{ parameters.PRNumber }} -commitSHA ${{ parameters.CommitSHA }} -enforceLatestCommit ${{ iif(parameters.EnforceLatestCommit, '1', '0') }}"
202180
condition: succeeded()
203181

182+
- task: Powershell@2
183+
name: FancyBuild
184+
displayName: Setting FancyBuild.BuildNumber
185+
inputs:
186+
targetType: inline
187+
script: |
188+
$authorName = git log -1 --pretty=format:"%an" ${{ parameters.CommitSHA }}
189+
190+
$buildNumberName = "$(OriginalBuildNumber) - $($authorName) - '${{ parameters.PRNumber }}'"
191+
$buildNumberName = $buildNumberName -replace '["/:<>\|?@*]','_'
192+
# Maximum buildnumber length is 255 chars and we are going to append to the end to ensure we have space.
193+
if ($buildNumberName.Length -GT 253) {
194+
$buildNumberName = $buildNumberName.Substring(0, 253)
195+
}
196+
# Avoid ever ending the BuildNumber with a `.` by always appending to it.
197+
$buildNumberName += ' #'
198+
Write-Host "##vso[task.setvariable variable=BuildNumber;isoutput=true;isreadonly=true]$buildNumberName"
199+
Write-Host "##vso[build.updatebuildnumber]$buildNumberName"
200+
204201
- powershell: Write-Host "##vso[task.setvariable variable=VisualStudio.DropName]Products/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranchName)/$(OriginalBuildNumber)"
205202
displayName: Setting VisualStudio.DropName variable
206203

0 commit comments

Comments
 (0)