Remove RegisterLanguageServer helper

This isn't doing anything interesting.

Author: jasonmalinowski

src/VisualStudio/Core/Def/LanguageService/AbstractPackage`2.cs

@@ -63,32 +63,33 @@ private async Task PackageInitializationMainThreadAsync(PackageLoadTasks package
 
     private Task PackageInitializationBackgroundThreadAsync(PackageLoadTasks packageInitializationTasks, CancellationToken cancellationToken)
     {
-        RegisterLanguageService(typeof(TLanguageService), async cancellationToken =>
-        {
-            // Ensure we're on the BG when creating the language service.
-            await TaskScheduler.Default;
-
-            var languageService = CreateLanguageService();
-            languageService.Setup(cancellationToken);
-
-            // DevDiv 753309:
-            // We've redefined some VS interfaces that had incorrect PIAs. When 
-            // we interop with native parts of VS, they always QI, so everything
-            // works. However, Razor is now managed, but assumes that the C#
-            // language service is native. When setting breakpoints, they
-            // get the language service from its GUID and cast it to IVsLanguageDebugInfo.
-            // This would QI the native lang service. Since we're managed and
-            // we've redefined IVsLanguageDebugInfo, the cast
-            // fails. To work around this, we put the LS inside a ComAggregate object,
-            // which always force a QueryInterface and allow their cast to succeed.
-            // 
-            // This also fixes 752331, which is a similar problem with the 
-            // exception assistant.
-
-            // Creating the com aggregate has to happen on the UI thread.
-            await this.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken);
-            return Interop.ComAggregate.CreateAggregatedObject(languageService);
-        });
+        AddService(typeof(TLanguageService), async (_, cancellationToken, _) =>
+            {
+                // Ensure we're on the BG when creating the language service.
+                await TaskScheduler.Default;
+
+                var languageService = CreateLanguageService();
+                languageService.Setup(cancellationToken);
+
+                // DevDiv 753309:
+                // We've redefined some VS interfaces that had incorrect PIAs. When 
+                // we interop with native parts of VS, they always QI, so everything
+                // works. However, Razor is now managed, but assumes that the C#
+                // language service is native. When setting breakpoints, they
+                // get the language service from its GUID and cast it to IVsLanguageDebugInfo.
+                // This would QI the native lang service. Since we're managed and
+                // we've redefined IVsLanguageDebugInfo, the cast
+                // fails. To work around this, we put the LS inside a ComAggregate object,
+                // which always force a QueryInterface and allow their cast to succeed.
+                // 
+                // This also fixes 752331, which is a similar problem with the 
+                // exception assistant.
+
+                // Creating the com aggregate has to happen on the UI thread.
+                await this.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken);
+                return Interop.ComAggregate.CreateAggregatedObject(languageService);
+            },
+            promote: true);
 
         // Misc workspace has to be up and running by the time our package is usable so that it can track running
         // doc events and appropriately map files to/from it and other relevant workspaces (like the
@@ -148,9 +149,6 @@ protected override async Task LoadComponentsAsync(CancellationToken cancellation
     protected abstract IEnumerable<IVsEditorFactory> CreateEditorFactories();
     protected abstract TLanguageService CreateLanguageService();
 
-    protected void RegisterLanguageService(Type t, Func<CancellationToken, Task<object>> serviceCreator)
-        => AddService(t, async (container, cancellationToken, type) => await serviceCreator(cancellationToken).ConfigureAwait(true), promote: true);
-
     protected override void Dispose(bool disposing)
     {
         if (disposing)

src/VisualStudio/VisualBasic/Impl/LanguageService/VisualBasicPackage.vb

@@ -4,6 +4,7 @@
 
 Imports System.ComponentModel.Design
 Imports System.Runtime.InteropServices
+Imports System.Threading
 Imports Microsoft.CodeAnalysis
 Imports Microsoft.CodeAnalysis.ErrorReporting
 Imports Microsoft.CodeAnalysis.Options
@@ -59,7 +60,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.VisualBasic
         Public Sub New()
             MyBase.New()
 
-            ' This is a UI-affinitized operation. Currently this opeartion prevents setting AllowsBackgroundLoad for
+            ' This is a UI-affinitized operation. Currently this operation prevents setting AllowsBackgroundLoad for
             ' VisualBasicPackage. The call should be removed from the constructor, and the package set back to allowing
             ' background loads.
             _comAggregate = Implementation.Interop.ComAggregate.CreateAggregatedObject(Me)
@@ -73,7 +74,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.VisualBasic
                 isMainThreadTask:=False,
                 task:=Function() As Task
                           Try
-                              RegisterLanguageService(GetType(IVbCompilerService), Function() Task.FromResult(_comAggregate))
+                              AddService(GetType(IVbCompilerService), Function(_1, cancellationToken, _2) Task.FromResult(_comAggregate), promote:=True)
 
                               DirectCast(Me, IServiceContainer).AddService(
                                   GetType(IVbTempPECompilerFactory),