Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the open to closed pump with a proper web hook running in Azure #10854

Closed
jasonmalinowski opened this issue Apr 25, 2016 · 4 comments
Closed

Comments

@jasonmalinowski
Copy link
Member

Our current tool has many problems with it:

  1. It's running on a fixed machine, which means we lose the pump if the machine goes offline.
  2. It has a configured set of branches, when it should really work on all branches as long as the same name exists in opened and closed.
  3. It's mirroring to VSTS as well, which we are obsoleting with the move to MicroBuild v2

@jaredpar has proposed that if we replace this with a GitHub webhook that responds on a push to our branch, and that the webhook just lives in Azure, then we can solve both of these issues.

@agocke
Copy link
Member

agocke commented Sep 7, 2016

This is obsolete -- we shouldn't need a pump any more.

@agocke agocke closed this as completed Sep 7, 2016
@agocke agocke removed their assignment Sep 7, 2016
@jasonmalinowski
Copy link
Member Author

@agocke We still have the pump for integration testing. What's the plan for that?

@agocke
Copy link
Member

agocke commented Sep 7, 2016

@jasonmalinowski Ah I forgot about that.

@jasonmalinowski
Copy link
Member Author

It's definitely obsolete now. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants