Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project System: Up-to-date check #10886

Closed
davkean opened this issue Apr 26, 2016 · 5 comments
Closed

Project System: Up-to-date check #10886

davkean opened this issue Apr 26, 2016 · 5 comments

Comments

@davkean
Copy link
Member

davkean commented Apr 26, 2016

CPS does not provide a project system up-to-date check out of the box - to get a similar experience to csproj/msvbproj where they only call MSBuild after they've determined that they are out of date, we should implement one.

Things to note:

  1. Unlike csproj/msvbproj, we should always write to the output window why we ended up calling MSBuild. Currently, you need to set a registry key to do this in csproj, extremely undiscoverable.

  2. Make sure we handle situations, such as WinMDs - where the binary copied to the output is the not the same as the binary as csc produced.

  3. Make sure we handle empty VSIX projects where CopyBuildOutputToOutputDirectory is set to false.

  4. Ideally, we'll add some telemetry to also track why the project system choose to rebuild, then we can find and fix top issues.

@davkean
Copy link
Member Author

davkean commented Apr 29, 2016

tag @KirillOsenkov

@davkean
Copy link
Member Author

davkean commented Apr 29, 2016

@KirillOsenkov
Copy link
Member

tag @ljcollins25

@davkean
Copy link
Member Author

davkean commented May 3, 2016

It looks like <UseCommonOutputDirectory>true</UseCommonOutputDirectory> also breaks csproj's update to-date-check:

1>Project 'Microsoft.VisualStudio.ProjectSystem.Managed' is not up to date. CopyLocal reference 'C:\Roslyn With Spaces\Binaries\Debug\Microsoft.Build.dll' is missing from output location.

@davkean
Copy link
Member Author

davkean commented May 13, 2016

This issue was moved to dotnet/project-system#62

@davkean davkean closed this as completed May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants