Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused usings feature does not deal with trivia correctly #1322

Closed
shyamnamboodiripad opened this issue Mar 17, 2015 · 0 comments · Fixed by #59276
Closed

Unused usings feature does not deal with trivia correctly #1322

shyamnamboodiripad opened this issue Mar 17, 2015 · 0 comments · Fixed by #59276
Labels
Area-Analyzers Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
Backlog

Comments

@shyamnamboodiripad
Copy link
Contributor

Unused usings diagnostic analyzer greys out contiguous unused usings. However, it only greys out trivia that is between the first and last unused usings - it does not grey out trivia present on the first or last unused using (notice how the last comment below is not greyed out)
1

The code fix however removes everything (including trivia present on the first and last unused using)
2
@shyamnamboodiripad shyamnamboodiripad modified the milestone: 1.0 (stable) Mar 17, 2015
@srivatsn srivatsn added this to the Unknown milestone Mar 26, 2015
@srivatsn srivatsn added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Mar 26, 2015
@CyrusNajmabadi CyrusNajmabadi mentioned this issue Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Analyzers Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix fading span for unnecessary using CyrusNajmabadi/roslyn
2 participants
@srivatsn @shyamnamboodiripad