Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: add a null-coalescing-assignment operator #13628

Closed
emsaks opened this issue Sep 6, 2016 · 4 comments
Closed

Proposal: add a null-coalescing-assignment operator #13628

emsaks opened this issue Sep 6, 2016 · 4 comments

Comments

@emsaks
Copy link

emsaks commented Sep 6, 2016

It would be nice to have a null-coalescing assignment operator, like so:

buffers[i] ??= new byte[4*1024*1024];

This would help in a case where one operation doesn't need all of the buffers, so it only initializes some of them, and a subsequent operation needs to utilize more of them - instead of re-initializing all of the buffers, it reuse previous ones and only initialize the indices that are null. Currently, the code would look like this:

for (int i; i < MAX_IO; i++)
{
buffers[i] = buffers[i] ?? new byte[4*1024*1024];
}

which could be simplified using the proposed operator.

@svick
Copy link
Contributor

svick commented Sep 6, 2016

This is a duplicate of #205 (and few other issues), which was closed by @gafter:

The benefits of this proposal do not overcome the drawbacks in terms of language complexity. It is unlikely to ever have a high enough benefit-for-cost to make us prefer it over many other things we could do in this release or many releases into the future.

@ashmind
Copy link
Contributor

ashmind commented Sep 8, 2016

I think it's worth having, and in fact I did a prototype in the thread linked above (TryRoslyn link is https://is.gd/BOcmcy). It does not include ||= and &&=, but a full implementation should consider those as they play a similar role.

The implementation isn't too hard, aside from questions in IDE support where I didn't fully understand the implications. It's a conversion — prototype does x = x ?? y, though now I think it should be if (x == null) x = y;

@alrz
Copy link
Contributor

alrz commented Sep 8, 2016

@ashmind I think in the expression context x ??= y should be translated to (x ?? (x = y)) and in the statement context it'll be if((object)x==null) x = y; . I'm not sure about x ??= y ??= z;.

@gafter
Copy link
Member

gafter commented Jan 8, 2018

We are now taking language feature discussion in other repositories:

Features that are under active design or development, or which are "championed" by someone on the language design team, have already been moved either as issues or as checked-in design documents. For example, the proposal in this repo "Proposal: Partial interface implementation a.k.a. Traits" (issue 16139 and a few other issues that request the same thing) are now tracked by the language team at issue 52 in https://github.com/dotnet/csharplang/issues, and there is a draft spec at https://github.com/dotnet/csharplang/blob/master/proposals/default-interface-methods.md and further discussion at issue 288 in https://github.com/dotnet/csharplang/issues. Prototyping of the compiler portion of language features is still tracked here; see, for example, https://github.com/dotnet/roslyn/tree/features/DefaultInterfaceImplementation and issue 17952.

In order to facilitate that transition, we have started closing language design discussions from the roslyn repo with a note briefly explaining why. When we are aware of an existing discussion for the feature already in the new repo, we are adding a link to that. But we're not adding new issues to the new repos for existing discussions in this repo that the language design team does not currently envision taking on. Our intent is to eventually close the language design issues in the Roslyn repo and encourage discussion in one of the new repos instead.

Our intent is not to shut down discussion on language design - you can still continue discussion on the closed issues if you want - but rather we would like to encourage people to move discussion to where we are more likely to be paying attention (the new repo), or to abandon discussions that are no longer of interest to you.

If you happen to notice that one of the closed issues has a relevant issue in the new repo, and we have not added a link to the new issue, we would appreciate you providing a link from the old to the new discussion. That way people who are still interested in the discussion can start paying attention to the new issue.

Also, we'd welcome any ideas you might have on how we could better manage the transition. Comments and discussion about closing and/or moving issues should be directed to #18002. Comments and discussion about this issue can take place here or on an issue in the relevant repo.


This may be close enough to dotnet/csharplang#34 that discussion can continue there.

@gafter gafter closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants