Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CSharpParseOption constructors #16475

Closed
heejaechang opened this issue Jan 12, 2017 · 4 comments
Closed

Simplify CSharpParseOption constructors #16475

heejaechang opened this issue Jan 12, 2017 · 4 comments
Assignees
@OmarTawfik
Labels
Area-Compilers Bug
Milestone
15.3

Comments

@heejaechang
Copy link
Contributor

heejaechang commented Jan 12, 2017 •
edited
Loading

right now, CSharpParseOption constructors are a bit hard to reason what is called when for what.
http://source.roslyn.io/#Microsoft.CodeAnalysis.CSharp/CSharpParseOptions.cs,46

we should clean those up and remove ones that are not necessary.

see these for more info.
#15797
#16421
#15798
@heejaechang heejaechang mentioned this issue Jan 12, 2017
Merged
@AdamSpeight2008
Copy link
Contributor

AdamSpeight2008 commented Jan 14, 2017 •
edited
Loading

We should have more doc-comments on parts of roslyn.
@heejaechang
Are you sure? as the check is in the base constructor.

@gafter gafter added this to the 2.1 milestone Jan 17, 2017
@heejaechang
Copy link
Contributor Author

@AdamSpeight2008 Hi Adam. I am not sure which one are you talking about?

@jaredpar jaredpar added the Bug label Mar 9, 2017
@jaredpar jaredpar modified the milestones: 15.3, 15.1 Mar 9, 2017
@OmarTawfik
Copy link
Contributor

@heejaechang can you take a look at #17113? it is fixing the inconsistencies in parse options reported in #15900.

@OmarTawfik
Copy link
Contributor

Addressed in #17113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmarTawfik OmarTawfik

Labels
Area-Compilers Bug
Projects
None yet
Milestone
15.3
Development

No branches or pull requests
5 participants
@jaredpar @AdamSpeight2008 @heejaechang @gafter @OmarTawfik