Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UpgradeProject fixer to handle new LanguageVersion error code #17950

Closed
jcouv opened this issue Mar 17, 2017 · 1 comment
Closed

Update UpgradeProject fixer to handle new LanguageVersion error code #17950

jcouv opened this issue Mar 17, 2017 · 1 comment
Assignees
@jcouv
Labels
Area-Compilers Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
15.3

Comments

@jcouv
Copy link
Member

jcouv commented Mar 17, 2017 •
edited
Loading

Following up on #17894

We can't actually do this change now, because the master branch supports no syntax that will trigger this diagnostic, so there wouldn't be any way to test UpgradeProject. I'm going to add a new #VERSION pragma which should unblock this situation.
@jcouv jcouv added this to the 15.3 milestone Mar 17, 2017
@jcouv jcouv self-assigned this Mar 17, 2017
@jcouv
Copy link
Member Author

jcouv commented Mar 27, 2017

Fixed by #18045

@jcouv jcouv closed this as completed Mar 27, 2017
@jcouv jcouv added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
Area-Compilers Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
15.3
Development

No branches or pull requests
1 participant
@jcouv