Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache delegate for non-capturing local functions when caching delegates for static methods #19431

Closed
pawchen opened this issue May 11, 2017 · 2 comments

Comments

@pawchen
Copy link
Contributor

pawchen commented May 11, 2017

This issue is created in respond to #6642 (comment)

Currently #6642 avoids local functions completely, as local functions all appears IsStatic but they could capture things. When it makes into a feature branch, consider support them like non-capturing lambda.

Also need to consider what to do when the delegate type involves generic parameters from any local functions.

@jcouv
Copy link
Member

jcouv commented May 11, 2017

FYI @agocke (relates to local functions)

@jcouv jcouv added the 4 - In Review A fix for the issue is submitted for review. label Aug 6, 2017
@gafter gafter removed the 4 - In Review A fix for the issue is submitted for review. label Dec 5, 2018
@gafter gafter added this to the Backlog milestone Dec 5, 2018
@pawchen
Copy link
Contributor Author

pawchen commented Jan 13, 2022

Closing as this is done in #58288. Just mark the targeting local function as static.

@pawchen pawchen closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants