Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to generate Operations.xml.Generated.cs? #19484

Closed
lachbaer opened this issue May 14, 2017 · 6 comments
Closed

How to generate Operations.xml.Generated.cs? #19484

lachbaer opened this issue May 14, 2017 · 6 comments
Labels
Area-Analyzers Contributor Pain The issue impedes progress for project collaborators. Feature - IOperation IOperation

Comments

@lachbaer
Copy link
Contributor

I need to alter Operations.xml.Generated.cs, but I don't find a corresponding XML file and generator in the repo. Can I do the changes manually?

@sharwell sharwell added Feature - IOperation IOperation Contributor Pain The issue impedes progress for project collaborators. labels May 14, 2017
@lachbaer
Copy link
Contributor Author

Does anyone has a preliminary answer?

@CyrusNajmabadi
Copy link
Member

IOPeration is currently being developed. If you want to make any changes, just edit the file directly. However, it's likely that that work may just be blown away as @heejaechang and others continue work in this area.

What are you trying to do?

@lachbaer
Copy link
Contributor Author

@CyrusNajmabadi

    /// <summary>
    /// Represents an expression that tests if a value is not of a specific type.
    /// </summary>
    /// <remarks>
    /// This interface is reserved for implementation by its associated APIs. We reserve the right to
    /// change it in the future.
    /// </remarks>
    internal sealed partial class IsnotTypeExpression : Operation, IIsnotTypeExpression
    {
        public IsnotTypeExpression(IOperation operand, ITypeSymbol isnotType, bool isInvalid, SyntaxNode syntax, ITypeSymbol type, Optional<object> constantValue) :
            base(OperationKind.IsnotTypeExpression, isInvalid, syntax, type, constantValue)
        {
            Operand = operand;
            IsnotType = isnotType;
        }
        /// <summary>
        /// Value to test.
        /// </summary>
        public IOperation Operand { get; }
        /// <summary>
        /// Type for which to test.
        /// </summary>
        public ITypeSymbol IsnotType { get; }
        public override void Accept(OperationVisitor visitor)
        {
            visitor.VisitIsnotTypeExpression(this);
        }
        public override TResult Accept<TArgument, TResult>(OperationVisitor<TArgument, TResult> visitor, TArgument argument)
        {
            return visitor.VisitIsnotTypeExpression(this, argument);
        }
    }

@lachbaer
Copy link
Contributor Author

lachbaer commented May 16, 2017

Little side node: I added IIsnotTypeExpression.cs to the project, without errors(!), but the project does not include the type, so that the interface inheritance above does not resolve. I had this resolved by closing IDE, cleaning and rebuilding, but nevertheless it keeps occuring from time to time. Can this be a bug?
PS: The same occurs on LocalRewriter_IsnotOperatorExpressions.cs

@heejaechang
Copy link
Contributor

sorry. the generator is not in yet. for now, if you want, you can add one manually along with the interfaces.

I am wondering whether what you are seeing is just timing issue or actual functional issue. when it happens again next time, can you close all opened documents, and only open the file that shows the error? and see whether it gets removed?

@jinujoseph
Copy link
Contributor

Closing this as this is tracked here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Analyzers Contributor Pain The issue impedes progress for project collaborators. Feature - IOperation IOperation
Projects
None yet
Development

No branches or pull requests

6 participants