Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the IOperation unit test dump format for child nodes #19866

Closed
mavasani opened this issue May 30, 2017 · 1 comment
Closed

Change the IOperation unit test dump format for child nodes #19866

mavasani opened this issue May 30, 2017 · 1 comment
Assignees
Labels
Area-Analyzers Feature - IOperation IOperation Test Test failures in roslyn-CI
Milestone

Comments

@mavasani
Copy link
Contributor

Currently, the dump prints the first child on the same line as the children header, which makes reviewing the dump very tedious. @AlekseyTs and @jcouv have both requested to change this format to dump the first child node on a new line.

It is a single line change in the dumper: we just need to append Environment.NewLine to the string argument passed to this LogString call: http://source.roslyn.io/#Roslyn.Test.Utilities/Compilation/OperationTreeVerifier.cs,245

However, this will need to update the expected output for almost all of the existing IOperation unit tests. We should do this sooner rather than later though.

@jinujoseph Can we get the vendors do this task as soon as possible?

@jinujoseph
Copy link
Contributor

closed via #20716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Analyzers Feature - IOperation IOperation Test Test failures in roslyn-CI
Projects
None yet
Development

No branches or pull requests

2 participants