Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go To Definition and Go To Implementation should be ref assembly aware. #21217

Closed
tannergooding opened this issue Jul 31, 2017 · 5 comments
Closed
Labels
Resolution-Not Reproducible The described behavior could not be reproduced by developers

Comments

@tannergooding
Copy link
Member

When using the new 'reference assembly' feature of the compiler, the IDE takes you to the metadata view when using 'Go To Definition' and displays a dialog indicating "The symbol has no implementations" when using 'Go To Implementation'

I would expect the IDE to be 'aware' of this feature and to still take you to the source file in the solution.

@CyrusNajmabadi
Copy link
Member

This is unrelated to the actual features, and is more about what the project-system/workspace do here. It sounds like they're attaching ref-assemblies as actual assemblies, instead of as P2P references. Tagging @jasonmalinowski

@Pilchie
Copy link
Member

Pilchie commented Jul 31, 2017

@tannergooding do you have #20833 @sharwell already added some support there.

@tannergooding
Copy link
Member Author

@Pilchie, this was on vsuml.26724.4002

@sharwell
Copy link
Member

@tannergooding I just tested this with 15.3 Preview 6 and both Go To Definition and Go To Implementation were working as expected. I enabled the feature like this for testing:

<PropertyGroup>
  <ProduceReferenceAssembly>true</ProduceReferenceAssembly>
  <CompileUsingReferenceAssemblies>true</CompileUsingReferenceAssemblies>
</PropertyGroup>

@tannergooding
Copy link
Member Author

Ok. I confirmed this is fixed in 15.3 Preview 6. It seems VSUML doesn't have the change yet.

@sharwell sharwell added the Resolution-Not Reproducible The described behavior could not be reproduced by developers label Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Not Reproducible The described behavior could not be reproduced by developers
Projects
None yet
Development

No branches or pull requests

4 participants