Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make variable decelaration of "Pattern matching" implicit (instead of explicit) #22126

Closed
MkazemAkhgary opened this issue Sep 14, 2017 · 1 comment
Labels
Area-Language Design Resolution-External The behavior lies outside the functionality covered by this repository

Comments

@MkazemAkhgary
Copy link

Version Used: 15.3.4
Steps to Reproduce:

var apple = new Apple();
// ...
foreach (var item in Items)
{
    if (item is Apple apple) // error, local variable can not be declared in this scope.
    {
    }
}

Expected Behavior:
It would be better to declare apple implicitly, that is, if its already declared, reuse it. if not declare it.
It is reasonable to issue compile time error if type of variables doesn't match.

The same behavior could be applied to other pattern matching like switch statement.
Actual Behavior:
This code causes compile time error, variable can not be declared in this scope.

@gafter
Copy link
Member

gafter commented Sep 15, 2017

We are now taking language feature discussion in other repositories:

Features that are under active design or development, or which are "championed" by someone on the language design team, have already been moved either as issues or as checked-in design documents. For example, the proposal in this repo "Proposal: Partial interface implementation a.k.a. Traits" (issue 16139 and a few other issues that request the same thing) are now tracked by the language team at issue 52 in https://github.com/dotnet/csharplang/issues, and there is a draft spec at https://github.com/dotnet/csharplang/blob/master/proposals/default-interface-methods.md and further discussion at issue 288 in https://github.com/dotnet/csharplang/issues. Prototyping of the compiler portion of language features is still tracked here; see, for example, https://github.com/dotnet/roslyn/tree/features/DefaultInterfaceImplementation and issue 17952.

In order to facilitate that transition, we have started closing language design discussions from the roslyn repo with a note briefly explaining why. When we are aware of an existing discussion for the feature already in the new repo, we are adding a link to that. But we're not adding new issues to the new repos for existing discussions in this repo that the language design team does not currently envision taking on. Our intent is to eventually close the language design issues in the Roslyn repo and encourage discussion in one of the new repos instead.

Our intent is not to shut down discussion on language design - you can still continue discussion on the closed issues if you want - but rather we would like to encourage people to move discussion to where we are more likely to be paying attention (the new repo), or to abandon discussions that are no longer of interest to you.

If you happen to notice that one of the closed issues has a relevant issue in the new repo, and we have not added a link to the new issue, we would appreciate you providing a link from the old to the new discussion. That way people who are still interested in the discussion can start paying attention to the new issue.

Also, we'd welcome any ideas you might have on how we could better manage the transition. Comments and discussion about closing and/or moving issues should be directed to #18002. Comments and discussion about this issue can take place here or on an issue in the relevant repo.


I have not moved this feature request to the csharplang repo because it would change the behavior of existing programs (e.g. where a field of the given name is already in scope).

@gafter gafter closed this as completed Sep 15, 2017
@gafter gafter added Area-Language Design Resolution-External The behavior lies outside the functionality covered by this repository labels Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Language Design Resolution-External The behavior lies outside the functionality covered by this repository
Projects
None yet
Development

No branches or pull requests

2 participants