Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reference when awaiting custom GetAwaiter method #25714

Closed
HaloFour opened this issue Mar 26, 2018 · 2 comments · Fixed by #28230
Closed

No reference when awaiting custom GetAwaiter method #25714

HaloFour opened this issue Mar 26, 2018 · 2 comments · Fixed by #28230
Assignees
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@HaloFour
Copy link

Version Used: v15.6.4

Steps to Reproduce:

  1. Create a class with a custom GetAwaiter that returns an awaitable.
  2. Instantiate that class and await on it from a separate async method.

Expected Behavior:

That the GetAwaiter method shows references from being used in an await expression.

Actual Behavior:

image

@HaloFour
Copy link
Author

Whether or not the method is shown as having a reference is a bit inconsistent between features. For example, GetEnumerator and Deconstruct do reflect the reference if used with foreach or deconstruction respectively. But LINQ-compatible methods don't appear to reflect the reference if used from LINQ query syntax.

@jcouv jcouv added the Area-IDE label Mar 26, 2018
@jinujoseph jinujoseph added this to the Unknown milestone Apr 20, 2018
@jcouv jcouv self-assigned this Jun 30, 2018
@jcouv jcouv added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Jun 30, 2018
@jcouv jcouv modified the milestones: Unknown, 15.8 Jun 30, 2018
@jinujoseph jinujoseph added the Bug label Jul 2, 2018
@jcouv
Copy link
Member

jcouv commented Jul 3, 2018

Fix will ship in 15.8.Preview5.

@jcouv jcouv added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants