Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests for pattern using #28102

Closed
agocke opened this issue Jun 25, 2018 · 1 comment
Closed

More tests for pattern using #28102

agocke opened this issue Jun 25, 2018 · 1 comment
Assignees
Labels
Area-Compilers Test Test failures in roslyn-CI
Milestone

Comments

@agocke
Copy link
Member

agocke commented Jun 25, 2018

Follow up to #27729

Jared suggested a variety of useful tests that weren't included in the original PR. They are:

  • Tests to ensure we bind correctly when presented with the pattern + an interface implementation
  • Tests where the receiver is a generic parameter constrained
    • To an interface that implements an interface that meets the disposable pattern but is not IDisposable
    • To an interface that implements an interface that meets the disposable pattern and implements IDisposable
    • To an interface that does not meet the disposable pattern directly but indirectly through an extension method.
    • The first two items above but additionally with the struct constraint and IL verification that we call Dispose in a non-boxing fashion.

We should follow up with these before merging the final feature branch.

@agocke agocke added Area-Compilers Test Test failures in roslyn-CI labels Jun 25, 2018
@agocke agocke added this to the 16.0 milestone Jun 25, 2018
@agocke agocke assigned chsienki and unassigned fayrose Aug 7, 2018
@jinujoseph jinujoseph modified the milestones: 16.0, 16.3 Jun 9, 2019
@gafter gafter modified the milestones: 16.3, 16.4 Sep 12, 2019
@chsienki
Copy link
Contributor

These are no longer relevant; the only time we allow pattern based disposal is for ref structs, which can't implement interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Test Test failures in roslyn-CI
Projects
None yet
Development

No branches or pull requests

5 participants