Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SymbolDisplay option to append suffix for unannotated reference types #28242

Closed
cston opened this issue Jul 2, 2018 · 3 comments
Closed

Comments

@cston
Copy link
Member

cston commented Jul 2, 2018

There are currently SymbolDisplay options to append a suffix for the display of nullable and non-nullable reference types. Consider appending a suffix for unannotated types as well, perhaps ~.

string?
string!
string~

Perhaps rename the existing IncludeNonNullableTypeModifier option and use a single option to specify whether a suffix is added for non-nullable and unannotated types.

@cston
Copy link
Member Author

cston commented Jul 2, 2018

cc @jcouv

@jcouv jcouv added this to the 16.0 milestone Jul 2, 2018
@jaredpar jaredpar added the Bug label Aug 30, 2018
@gafter gafter modified the milestones: 16.0, 16.1 Feb 26, 2019
@jaredpar jaredpar modified the milestones: 16.1, Compiler.Next Apr 9, 2019
@jcouv
Copy link
Member

jcouv commented Jul 16, 2019

@jasonmalinowski @333fred @cston Do you think we need such an option?
I'm tempted to close this issue until we have an explicit driving scenario.

@333fred
Copy link
Member

333fred commented Jul 16, 2019

I would agree. No one but the compiler team would even understand what a ~ even means.

@cston cston closed this as completed Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants