You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have some overload of Create which default to placeholder contexts (NonNullTypesTrueContext or NonNullTypesFalseContext).
Those overloads should be removed and proper/explicit contexts should be used in most places, if not all.
' The NonNullTypes context for nested tuple types is using a dummy rather than actual context from surrounding code.
' This does not affect `IsNullable`, but it affects `IsAnnotatedWithNonNullTypesContext`, which is used in comparisons.
' So when we copy modifiers (re-applying nullability information, including actual NonNullTypes context), we make the comparison fail.
' I think the solution is to never use a dummy context, even for value types.
<Fact(Skip:="PROTOTYPE(NullableReferenceTypes): Hitting assertion in CopyTypeCustomModifiers")>
Public Sub TupleNamesFromCS001()
We currently have some overload of
Create
which default to placeholder contexts (NonNullTypesTrueContext
orNonNullTypesFalseContext
).Those overloads should be removed and proper/explicit contexts should be used in most places, if not all.
Relates to #28487
The text was updated successfully, but these errors were encountered: