Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last token in type name for #nullable context #30985

Closed
cston opened this issue Nov 6, 2018 · 2 comments
Closed

Use last token in type name for #nullable context #30985

cston opened this issue Nov 6, 2018 · 2 comments
Labels
Area-Compilers Bug Feature - Nullable Reference Types Nullable Reference Types Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@cston
Copy link
Member

cston commented Nov 6, 2018

Use the last token in the type name for the #nullable context. For instance, use the ] for arrays and > for constructed types.

using System.Collections.Generic;

class Program
{
#nullable disable
    string
#nullable enable
        [] names; // string~[]!

    Dictionary<string,
#nullable disable
        string>
#nullable enable
        map;      // Dictionary<string!, string~>~
}
@jaredpar jaredpar added the Bug label Nov 13, 2018
@jaredpar jaredpar added this to the 16.0 milestone Nov 13, 2018
@jcouv
Copy link
Member

jcouv commented Jan 30, 2019

@cston @AlekseyTs I think that was already implemented by Aleksey in #31607
If there is a remaining issue, could you clarify it?
Otherwise, please close

@gafter gafter modified the milestones: 16.0, 16.1 Feb 26, 2019
@jcouv jcouv added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Mar 10, 2019
@jcouv
Copy link
Member

jcouv commented Mar 14, 2019

@cston Do we need to keep this issue open?

@cston cston closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Bug Feature - Nullable Reference Types Nullable Reference Types Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

4 participants