Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSA reports warnings about nullability needing to be enabled #31870

Closed
Pilchie opened this issue Dec 17, 2018 · 3 comments · Fixed by #32726
Closed

FSA reports warnings about nullability needing to be enabled #31870

Pilchie opened this issue Dec 17, 2018 · 3 comments · Fixed by #32726
Assignees
@heejaechang
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug Feature - Nullable Reference Types Nullable Reference Types
Milestone
16.0.P3

Comments

@Pilchie
Copy link
Member

Pilchie commented Dec 17, 2018 •
edited
Loading

Version Used:
Version 16.0.0 Preview 2.0 [28414.103.d16.0stg]

Steps to Reproduce:

  1. Enable C# 8 and <NullableReferenceTypes>
  2. Annotate a bunch of code for nullability
  3. Turn FSA on.
  4. Close all files

Expected Behavior:
No warnings

Actual Behavior:
A bunch of warnings like:

Severity	Code	Description	Project	File	Line	Suppression State
Warning	CS8632	The annotation for nullable reference types should only be used in code within a '#nullable' context.	Microsoft.VisualStudio.ProjectSystem.Managed	C:\Code\project-system\src\Microsoft.VisualStudio.ProjectSystem.Managed\Composition\OrderPrecedenceImportCollectionExtensions.cs	59	Active
@Pilchie
Copy link
Member Author

Pilchie commented Dec 17, 2018

Tag @jinujoseph @heejaechang

@Pilchie
Copy link
Member Author

Pilchie commented Dec 18, 2018

@sharwell this is not a compilers issue. It's an issue with the OOP marshalling layer.

@jinujoseph jinujoseph added this to the 16.0.P2 milestone Dec 20, 2018
@jinujoseph
Copy link
Contributor

cc @jcouv

@jinujoseph jinujoseph modified the milestones: 16.0.P2, 16.0.P3 Jan 16, 2019
@heejaechang heejaechang mentioned this issue Jan 24, 2019
Merged
@jinujoseph jinujoseph added the 4 - In Review A fix for the issue is submitted for review. label Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heejaechang heejaechang

Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.0.P3
Development

Successfully merging a pull request may close this issue.

add new compilation options to data sync to OOP. heejaechang/roslyn
5 participants
@Pilchie @heejaechang @sharwell @vatsalyaagrawal @jinujoseph