Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .razor files #32570

Closed
danroth27 opened this issue Jan 17, 2019 · 5 comments
Closed

Add support for .razor files #32570

danroth27 opened this issue Jan 17, 2019 · 5 comments
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.
Milestone

Comments

@danroth27
Copy link
Member

ASP.NET Core 3.0 adds support for Razor Components, a new way to write client-side web UI. Razor Component files are Razor files (like .cshtml files) that get compiled to .NET classes that render to a structured presentation of the DOM. This allows the runtime to efficiently figure out exactly which parts of the DOM need to be updated. Because Razor Components use a fundamentally different compilation model from MVC views/pages they will have a different file extension: .razor.

Broadly speaking we need all our partner teams that special case .cshtml files today to also support .razor files. In .razor files you should get a rich C# editing experience and rich debugging experience in both web and class libraries just like you do with .cshtml files today. We want to land this work to support .razor files in the first update preview of VS2019 so that folks can start trying it out with the new Razor Component support in .NET Core 3.0.

@kendrahavens @rynowak @jinujoseph @heejaechang @jasonmalinowski

@jinujoseph jinujoseph added Area-IDE Need Design Review The end user experience design needs to be reviewed and approved. labels Jan 17, 2019
@jinujoseph jinujoseph added this to the 16.1.P1 milestone Jan 17, 2019
@rynowak
Copy link
Member

rynowak commented Jan 17, 2019

To be super clear: the ask is to treat .razor the same as .cshtml. If you any places in code that special case .cshtml based on the file extension then they need to be updated.

If you have places in code that special case Razor via editor content-type, then that is not impacted and does not need to change.

@rynowak
Copy link
Member

rynowak commented Jan 17, 2019

I did a github search and didn't find any instances of this other than a few unit tests. https://github.com/dotnet/roslyn/search?p=2&q=%22.cshtml%22&unscoped_q=%22.cshtml%22

Most of the occurrences are in comments

@heejaechang
Copy link
Contributor

I don't think we care about file extension as long as project system feed that to us like cshtml through you guys to us for closed file FAR. and open file as contained document for now.

@rynowak
Copy link
Member

rynowak commented Feb 28, 2019

Yeah, I'm not aware of any issue, and I didn't find any code in your repo that hardcodes the file extension. So I think that this can be closed if you think there is nothing to do.

The project system already did the work for for this in their 16.1 branch.

@jinujoseph jinujoseph modified the milestones: 16.1.P1, 16.2 Apr 24, 2019
@jinujoseph jinujoseph modified the milestones: 16.2, Backlog Jun 9, 2019
@sharwell sharwell moved this to In Queue in IDE: Design review Aug 22, 2023
@CyrusNajmabadi
Copy link
Member

Closing out. This would go to the razor team.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2024
@dotnet dotnet locked as resolved and limited conversation to collaborators Oct 20, 2024
@CyrusNajmabadi CyrusNajmabadi moved this from In Queue to Complete in IDE: Design review Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.
Projects
Status: Complete
Development

No branches or pull requests

5 participants