Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] Fix alls have started running in generated code #33507

Closed
davkean opened this issue Feb 20, 2019 · 1 comment
Closed

[Regression] Fix alls have started running in generated code #33507

davkean opened this issue Feb 20, 2019 · 1 comment
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug IDE-CodeStyle Built-in analyzers, fixes, and refactorings Regression Urgency-Now
Milestone
16.0.P4

Comments

@davkean
Copy link
Member

davkean commented Feb 20, 2019 •
edited
Loading

This was fixed during the Dev15 cycle, but seems to have been regressed again.

> git clone http://github.com/dotnet/project-system
> cd project-system
project-system> git checkout 9bac1e669c67e5d0c44486be595d7ec6323461ca
project-system> build.cmd
project-system> ProjectSystem.sln
  1. Navigate to ActiveEditorContextTracker.cs
  2. Drop the code fix over using System.Threading.Tasks to Remove unnecessary usings -> Solution

Expected: (15.9)
Two results:
image

Actual: (16.0 Preview 4)
100s of results in auto-generated files:
image
@sharwell
Copy link
Member

Looks like I broke this in 1b402fb. Will fix it tomorrow.

@sharwell sharwell added Bug Area-IDE Urgency-Now Regression IDE-CodeStyle Built-in analyzers, fixes, and refactorings labels Feb 20, 2019
@sharwell sharwell added this to the 16.0.P4 milestone Feb 20, 2019
@sharwell sharwell self-assigned this Feb 20, 2019
@sharwell sharwell mentioned this issue Feb 20, 2019
Merged
@sharwell sharwell added the 4 - In Review A fix for the issue is submitted for review. label Feb 20, 2019
@ghost ghost closed this as completed in caedd4a Feb 21, 2019
@ghost ghost unassigned sharwell Feb 21, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug IDE-CodeStyle Built-in analyzers, fixes, and refactorings Regression Urgency-Now
Projects
None yet
Milestone
16.0.P4
Development

No branches or pull requests
2 participants
@davkean @sharwell