Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readonly members SymbolDisplay/MetadataAsSource #34650

Closed
RikkiGibson opened this issue Apr 1, 2019 · 2 comments
Closed

Readonly members SymbolDisplay/MetadataAsSource #34650

RikkiGibson opened this issue Apr 1, 2019 · 2 comments
Assignees
@RikkiGibson
Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Milestone
16.2.P1

Comments

@RikkiGibson
Copy link
Contributor

  • Make 'readonly' modifiers on methods, properties/indexers/events and accessors visible from metadata by updating MetadataAsSourceService
  • Make 'readonly' modifiers on members visible in Quick Info by updating SymbolDisplayVisitor.Members
@RikkiGibson RikkiGibson self-assigned this Apr 1, 2019
@RikkiGibson RikkiGibson mentioned this issue Apr 1, 2019
Closed
52 tasks
@jinujoseph jinujoseph added Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings labels Apr 3, 2019
@jinujoseph jinujoseph added this to the 16.1.P2 milestone Apr 3, 2019
This was referenced Apr 5, 2019
Merged
Merged
@jinujoseph jinujoseph modified the milestones: 16.1.P2, 16.1.P3, 16.1, 16.2.P1 Apr 23, 2019
@RikkiGibson
Copy link
Contributor Author

The PRs which contain the parts of this work are done, so I'll close this issue to reflect that.

@RikkiGibson
Copy link
Contributor Author

I just noticed that while the implicit 'readonly' does show in Quick Info for an auto-get accessor, it doesn't show on the property. Adding an explicit 'readonly' keyword makes it start showing in the accessor. I think this is because making the implicit 'readonly' on the property caused lots and lots of churn in symbol display tests. But it feels like the experience would be better if you always knew when accessing a member on a non-readonly struct, if that member itself is readonly.

image

image

image

@sharwell sharwell moved this to Need Update in IDE: Design review Aug 22, 2023
@CyrusNajmabadi CyrusNajmabadi moved this from Need Update to Complete in IDE: Design review Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RikkiGibson RikkiGibson

Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Projects
IDE: Design review
Status: Complete
Milestone
16.2.P1
Development

No branches or pull requests
2 participants
@RikkiGibson @jinujoseph