Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark calls to oblivious methods in #nullable contexts in Quick Info #41504

Open
jasonmalinowski opened this issue Feb 7, 2020 · 5 comments
Open
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-IntelliSense Completion, Signature Help, Quick Info
Milestone

Comments

@jasonmalinowski
Copy link
Member

Right now if you have a piece of code that is #nullable enabled and calls an oblivious method, you don't get any warnings to this effect. This is good because in a mixed codebase if you had compiler warnings this would quickly get really noisy. But, we should probably show some simple hint in Quick Info that lets the user know the call isn't being considered for nullability, so they know where the dragons may still lie.

@333fred's suggestion for the text was "This call is not null aware", which I think is a great wording.

@333fred
Copy link
Member

333fred commented Feb 7, 2020

And extend for property/field/etc.

@jasonmalinowski jasonmalinowski added this to the 16.6 milestone Feb 8, 2020
@gafter gafter added the Area-IDE label Feb 9, 2020
@vatsalyaagrawal vatsalyaagrawal modified the milestones: 16.6, 16.6.P1 Feb 13, 2020
@vatsalyaagrawal vatsalyaagrawal added Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-IntelliSense Completion, Signature Help, Quick Info labels Feb 13, 2020
@jinujoseph jinujoseph modified the milestones: 16.6.P1, 16.6 Mar 22, 2020
@jasonmalinowski jasonmalinowski modified the milestones: 16.6, 16.7 Apr 7, 2020
@jinujoseph jinujoseph modified the milestones: 16.7, Backlog Jun 19, 2020
@CyrusNajmabadi
Copy link
Member

Closing out due to lack of feedback.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
@dotnet dotnet locked and limited conversation to collaborators Oct 21, 2024
@333fred
Copy link
Member

333fred commented Oct 21, 2024

Sorry, I don't think we should close this out. There's plenty of feedback related to it:
#36983
#44063
#42318
#47481

@333fred 333fred reopened this Oct 21, 2024
@dotnet dotnet unlocked this conversation Oct 21, 2024
@jasonmalinowski
Copy link
Member Author

Agreed; this is still a common source of feedback.

@CyrusNajmabadi
Copy link
Member

Fine to reactivate this. But we should assign a person/milestone and actually ensure we're properly handling this feedback. If it's in the backlog, and untouched for N years, that's effectively us choosing to not do it. Conversing on wednesday on process changes to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-IntelliSense Completion, Signature Help, Quick Info
Projects
Status: InQueue
Development

No branches or pull requests

6 participants