Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MSBuild intrinsic function for target framework detection #46050

Open
chsienki opened this issue Jul 16, 2020 · 0 comments
Open

Use MSBuild intrinsic function for target framework detection #46050

chsienki opened this issue Jul 16, 2020 · 0 comments
Assignees
@chsienki
Labels
Area-Compilers Bug
Milestone
Backlog

Comments

@chsienki
Copy link
Contributor

chsienki commented Jul 16, 2020 •
edited
Loading

In #44911 we expanded the language version logic to pick the correct language version based on a combination of TargetFrameworkIdentifier / _TargetFrameworkVersionWithoutV (see https://github.com/dotnet/roslyn/pull/44911/files#r443010616)

With dotnet/msbuild#5234 MSBuild is adding a set of intrinsic functions that allow for rich TargetFramework based targeting. We should switch over to this mechanism once available. (See dotnet/msbuild#5171 for design)
@chsienki chsienki self-assigned this Jul 16, 2020
@chsienki chsienki mentioned this issue Jul 16, 2020
Merged
@chsienki chsienki added this to the Compiler.Next milestone Jul 16, 2020
@jaredpar jaredpar added the Bug label Jul 27, 2020
@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chsienki chsienki

Labels
Area-Compilers Bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@jaredpar @chsienki