Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend default constraint on overrides #46283

Closed
jcouv opened this issue Jul 23, 2020 · 0 comments · Fixed by #46311
Closed

Recommend default constraint on overrides #46283

jcouv opened this issue Jul 23, 2020 · 0 comments · Fixed by #46311
Assignees
@jcouv
Labels
Area-IDE Feature - Nullable Reference Types Nullable Reference Types IDE-IntelliSense Completion, Signature Help, Quick Info
Milestone
16.8

Comments

@jcouv
Copy link
Member

jcouv commented Jul 23, 2020

The default constraint is allowed in overrides and explicit interface implementations. We should recommend that keyword.

We should also consider not recommending type names in those contexts (we currently do).

Relates to #44578 (test plan for TUnconstrained?)
@jcouv jcouv added this to the 16.8 milestone Jul 23, 2020
@sharwell sharwell added the IDE-IntelliSense Completion, Signature Help, Quick Info label Jul 23, 2020
@jcouv jcouv mentioned this issue Jul 24, 2020
Merged
@jcouv jcouv self-assigned this Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
Area-IDE Feature - Nullable Reference Types Nullable Reference Types IDE-IntelliSense Completion, Signature Help, Quick Info
Projects
None yet
Milestone
16.8
Development

Successfully merging a pull request may close this issue.

Recommend default in type constraint, but not record jcouv/roslyn
2 participants
@sharwell @jcouv