Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up testing for notnull-param-state #46384

Open
RikkiGibson opened this issue Jul 28, 2020 · 0 comments
Open

Follow-up testing for notnull-param-state #46384

RikkiGibson opened this issue Jul 28, 2020 · 0 comments
Labels
Area-Compilers Test-Gap Describes a specific feature or scenario that does not have test coverage

Comments

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Jul 28, 2020

Consider making this test a [Theory] and using an argument to enumerate all the different constraint combinations where this is now valid.

Originally posted by @jaredpar in #46072 (comment)


Consider adding a test here there is an override that removes the nullability annotation and calls through both the base and derived type and shows the outcome on the null state of the argument. Basically making sure we are considering the base and derived method annotation as appropriate.

I actually can't remember off hand if we look at the declaration method or the override when considering annotations hence I can't remember what the correct behavior is here. Hence a test 😄

Originally posted by @jaredpar in #46072 (comment)

@RikkiGibson RikkiGibson added Area-Compilers Test-Gap Describes a specific feature or scenario that does not have test coverage labels Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Test-Gap Describes a specific feature or scenario that does not have test coverage
Projects
None yet
Development

No branches or pull requests

1 participant