Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal API to fold FlowAnalysisAnnotations into the symbol's TypeWithAnnotations #47635

Closed
RikkiGibson opened this issue Sep 11, 2020 · 1 comment
Assignees
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality

Comments

@RikkiGibson
Copy link
Contributor

Basically if you just access something like the TypeWithAnnotations on a symbol, and you don't try to "fold in" the FlowAnalysisAnnotations on that symbol into the TypeWithAnnotations, you probably have bugs related to nullability attributes. It does feel like there should be something like GetAdjustedTypeWithAnnotations() (strawman name) on certain kinds of symbols in order to make it easier to do the right thing.

Originally posted by @RikkiGibson in #47555 (comment)

@RikkiGibson
Copy link
Contributor Author

Closing as stale.

@RikkiGibson RikkiGibson closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Projects
None yet
Development

No branches or pull requests

1 participant