Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC: Adding/updating/removing attribute on local function, its return type or parameter should be rude edit #48636

Closed
tmat opened this issue Oct 15, 2020 · 2 comments · Fixed by #51086

Comments

@tmat
Copy link
Member

tmat commented Oct 15, 2020

Version Used:
Version 16.9.0 Preview 1.0 [30614.203.main]

It is currently rude edit to add/update/remove attributes on any member/parameter/return value, so for consistency we should report this rude edit on local function attributes as well.

Once support changing attributes we should remove the rude edit for local functions as well. Runtime support is required for such feature, so the rude edit would stay for .NET Framework apps.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 15, 2020
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 15, 2020
@jinujoseph jinujoseph added this to the 16.9 milestone Oct 15, 2020
@davidwengier davidwengier self-assigned this Oct 27, 2020
@davidwengier davidwengier modified the milestones: 16.9, 16.10 Jan 28, 2021
@lambdageek
Copy link
Member

This includes compiler generated attributes like changing a ref arguments to in? or changing object to object? ?

@tmat
Copy link
Member Author

tmat commented Feb 11, 2021

Both updates are currently treated as rude edits. Since the actual signature does not change we should consider allowing these changes.

@ghost ghost closed this as completed in #51086 Feb 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment