Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC: Allow adding/removing/updating attributes #49012

Closed
1 task
tmat opened this issue Oct 29, 2020 · 4 comments · Fixed by #52986
Closed
1 task

EnC: Allow adding/removing/updating attributes #49012

tmat opened this issue Oct 29, 2020 · 4 comments · Fixed by #52986

Comments

@tmat
Copy link
Member

tmat commented Oct 29, 2020

Allow all custom attributes on .NET Core.
Allow specific (nullability) custom attributes on .NET Framework.

  • Debugger needs to trigger an event that notifies Reflection to invalidate caches in the debuggee - via func-eval.
    The event has well-known full name with specific signature. It may be declared in any assembly and have any accessibility. Design with BCL.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 29, 2020
@tmat tmat changed the title EnC: Allow adding/removing/updating all attributes on .NET Core EnC: Allow adding/removing/updating attributes Oct 29, 2020
@jinujoseph jinujoseph added Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 4, 2020
@jinujoseph jinujoseph added this to the Backlog milestone Nov 4, 2020
@lambdageek
Copy link
Member

lambdageek commented Feb 11, 2021

Not sure about "all attributes on .NET Core". Some attributes are meaningful to the runtime in a way that editing them may not have the expected effect. (For example FieldOffsetAttribute on a struct with explicit layout).

@tmat
Copy link
Member Author

tmat commented Feb 11, 2021

@lambdageek Yes, we would need to exclude those. Note that these attributes are not real custom attributes. They are emitted as metadata flags. Updated the description to specifically say "custom" attributes.

@lambdageek
Copy link
Member

lambdageek commented Feb 19, 2021

@tmat it's not just pseudo custom attributes. It's also things like UnmanagedCallersOnlyAttribute and SuppressGCTransitionAttribute.

There should be a rude attributes list.

@tmat
Copy link
Member Author

tmat commented Feb 20, 2021

I see. We'll probably need to have a list of special ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants