Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sharing NullableWalker state between containing method and lambdas and local functions #49745

Closed
cston opened this issue Dec 2, 2020 · 2 comments · Fixed by #49765 or #50417
Closed

Avoid sharing NullableWalker state between containing method and lambdas and local functions #49745

cston opened this issue Dec 2, 2020 · 2 comments · Fixed by #49765 or #50417
Assignees
@cston
Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
16.9

Comments

@cston
Copy link
Member

cston commented Dec 2, 2020

When analyzing a method in NullableWalker, avoid sharing _variableTypes and _variableSlots between that method and any lambdas or local functions. If there are many nested functions, as there might be in generated code, adding entries in the tables for the containing method for parameters and local functions from the nested functions can significantly increase the amount of state that needs to be tracked.

See #49686.

cc @RikkiGibson
@cston cston self-assigned this Dec 2, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 2, 2020
@cston cston added New Language Feature - Nullable Reference Types Nullable Reference Types and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 2, 2020
@cston cston mentioned this issue Dec 3, 2020
Merged
@cston cston closed this as completed Dec 4, 2020
@cston cston reopened this Dec 4, 2020
@RikkiGibson
Copy link
Contributor

Is this issue meant to track the work to improve the data design for nullable analysis of nested functions?

@cston
Copy link
Member Author

cston commented Dec 8, 2020

Is this issue meant to track the work to improve the data design for nullable analysis of nested functions?

Yes.

@cston cston added this to the 16.9 milestone Jan 8, 2021
@cston cston mentioned this issue Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cston cston

Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.9
3 participants
@RikkiGibson @cston @Dotnet-GitSync-Bot