Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple file patterns in editorconfig don't work as expected #50577

Closed
Youssef1313 opened this issue Jan 18, 2021 · 2 comments · Fixed by #50608
Closed

Multiple file patterns in editorconfig don't work as expected #50577

Youssef1313 opened this issue Jan 18, 2021 · 2 comments · Fixed by #50608
Labels
4 - In Review A fix for the issue is submitted for review. Area-Infrastructure Concept-Continuous Improvement
Milestone
16.10

Comments

@Youssef1313
Copy link
Member

See e1e9fa4

Warnings from CA1822 weren't reported from the build of this commit.

It was only reported for 96b0f6d

However, the added line is already existing for src/VisualStudio in:

roslyn/.editorconfig

Line 264 in 96b0f6d

dotnet_diagnostic.CA1822.severity = warning

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 18, 2021
@Youssef1313
Copy link
Member Author

See also failures from this draft PR #50578 that happened when I copied settings under: [src/{Analyzers,CodeStyle,Features,Workspaces,EditorFeatures, VisualStudio}/**/*.{cs,vb}] to [src/{VisualStudio}/**/*.{cs,vb}].

I was expecting src/VisualStudio to have settings from both file patterns. That doesn't seem to be the case.

This was referenced Jan 18, 2021
Merged
Closed
@Youssef1313
Copy link
Member Author

The issue appears to be an extra space in .editorconfig introduced in:

5df1b61#diff-0947e2727d6bad8cd0ac4122f5314bb5b04e337393075bc4b5ef143b17fcbd5b

Some rules enforcement is now lost for VisualStudio layer. The issue can be closed once the space is removed and the violations are fixed.

@Youssef1313 Youssef1313 reopened this Jan 19, 2021
@Youssef1313 Youssef1313 mentioned this issue Jan 19, 2021
Merged
@jinujoseph jinujoseph added 4 - In Review A fix for the issue is submitted for review. Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 29, 2021
@jinujoseph jinujoseph added this to the 16.10 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4 - In Review A fix for the issue is submitted for review. Area-Infrastructure Concept-Continuous Improvement
Projects
None yet
Milestone
16.10
Development

Successfully merging a pull request may close this issue.

Fix extra space in editorconfig Youssef1313/roslyn
3 participants
@jaredpar @jinujoseph @Youssef1313