Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider explicit '#nullable' directives in source packages #50749

Open
sharwell opened this issue Jan 25, 2021 · 0 comments
Open

Consider explicit '#nullable' directives in source packages #50749

sharwell opened this issue Jan 25, 2021 · 0 comments
Assignees
@sharwell
Labels
Area-Infrastructure Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Need Design Review The end user experience design needs to be reviewed and approved.
Milestone
17.6 P2

Comments

@sharwell
Copy link
Member

Currently our source packages rely on consuming projects to set <Nullable> correctly. Another option is to explicitly place #nullable enable at the top of each file in these packages. If the latter option is preferred, it can be implemented once build validation is in place to ensure future commits do not remove any of the required directives.

Related to #50189 (comment)
@sharwell sharwell added Area-Infrastructure Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality labels Jan 25, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 25, 2021
@sharwell sharwell mentioned this issue Jan 25, 2021
Merged
@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 28, 2021
@jinujoseph jinujoseph added this to the 16.10 milestone Jan 28, 2021
@jinujoseph jinujoseph added the Need Design Review The end user experience design needs to be reviewed and approved. label Jan 28, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, 17.0 Jul 16, 2021
@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Oct 21, 2021
@jinujoseph jinujoseph modified the milestones: 17.1, 17.3 Apr 27, 2022
@arkalyanms arkalyanms modified the milestones: 17.3, 17.6 P2 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-Infrastructure Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Need Design Review The end user experience design needs to be reviewed and approved.
Projects
IDE: Design review
Status: Need Update
Milestone
17.6 P2
Development

No branches or pull requests
3 participants
@sharwell @jinujoseph @arkalyanms