Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow in SymbolEquivalenceComparer #50800

Closed
tmat opened this issue Jan 26, 2021 · 3 comments
Closed

Stack overflow in SymbolEquivalenceComparer #50800

tmat opened this issue Jan 26, 2021 · 3 comments
Assignees
Labels
Area-IDE Bug Tenet-Reliability Customer telemetry indicates that the product is failing in a crash/hang/dataloss manner.
Milestone

Comments

@tmat
Copy link
Member

tmat commented Jan 26, 2021

Moved from https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1124060

at mscorlib.ni!System.String.Equals in string.cs
at Microsoft.CodeAnalysis.CSharp!Microsoft.CodeAnalysis.CSharp.Symbols.NamedTypeSymbol.IsTupleTypeOfCardinality in NamedTypeSymbol.cs
at Microsoft.CodeAnalysis.CSharp!Microsoft.CodeAnalysis.CSharp.Symbols.NamedTypeSymbol.get_IsTupleType in TupleTypeSymbol.cs
at Microsoft.CodeAnalysis.CSharp!Microsoft.CodeAnalysis.CSharp.Symbols.NamedTypeSymbol.get_TupleData in TupleTypeSymbol.cs
at Microsoft.CodeAnalysis.CSharp!Microsoft.CodeAnalysis.CSharp.Symbols.NamedTypeSymbol.get_TupleElements in TupleTypeSymbol.cs
at Microsoft.CodeAnalysis.CSharp!Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel.NamedTypeSymbol.Microsoft.CodeAnalysis.INamedTypeSymbol.get_TupleElements in NamedTypeSymbol.cs
at Microsoft.CodeAnalysis.Workspaces!Microsoft.CodeAnalysis.Shared.Utilities.SymbolEquivalenceComparer in SymbolEquivalenceComparer.EquivalenceVisitor.cs
at Microsoft.CodeAnalysis.Workspaces!Microsoft.CodeAnalysis.Shared.Utilities.SymbolEquivalenceComparer in SymbolEquivalenceComparer.EquivalenceVisitor.cs
...
@tmat tmat added the Area-IDE label Jan 26, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 26, 2021
@jinujoseph jinujoseph added Bug Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead and removed untriaged Issues and PRs which have not yet been triaged by a lead Area-IDE labels Jan 26, 2021
@jaredpar jaredpar removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 26, 2021
@jaredpar jaredpar added this to the 16.9 milestone Jan 26, 2021
@AlekseyTs
Copy link
Contributor

@jinujoseph, @jaredpar SymbolEquivalenceComparer is in Workspaces layer. Moving this issue back to IDE area and marking it for triage.

@AlekseyTs AlekseyTs added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead Retriage and removed Area-Compilers labels Jan 27, 2021
@AlekseyTs AlekseyTs removed their assignment Jan 27, 2021
@sharwell
Copy link
Member

Assigning to @CyrusNajmabadi due to similarity to #41598/#42852, though this one seems to be in a newer version.

@sharwell sharwell added Tenet-Reliability Customer telemetry indicates that the product is failing in a crash/hang/dataloss manner. and removed Retriage untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 27, 2021
@CyrusNajmabadi
Copy link
Member

Discussed with Julien. Based on the date range of the hits (which we don't hav any more of), this was almost certainly fixed with #39370 and #41702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Tenet-Reliability Customer telemetry indicates that the product is failing in a crash/hang/dataloss manner.
Projects
None yet
Development

No branches or pull requests

6 participants