Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Razor design-time files in EnC #51265

Closed
jinujoseph opened this issue Feb 17, 2021 · 1 comment
Closed

Ignore Razor design-time files in EnC #51265

jinujoseph opened this issue Feb 17, 2021 · 1 comment

Comments

@jinujoseph
Copy link
Contributor

jinujoseph commented Feb 17, 2021

Razor produces design-time files to support tooling. We need to make sure these experiences aren't broken so that tooling keeps working they way they are today, while we support EnC

The current thinking is that we would use analyzer config file setting. Essentially, Razor nuget package would contain msbuild targets file that adds a root-level analyzer config file of a well known name (RazorSourceGenerator.razorencconfig) to the compilation, but only for design-time vs builds (there is an msbuild property that can be used for this condition). Razor source generator has access to any such config files. It would use it to decide which form of the source files it should generate (design-time file/runtime file). EnC would also insert this config file into the EnC compilation to force it to generate runtime files.

Removing this workaround is tracked by #51678

@jinujoseph jinujoseph added this to the 16.10 milestone Feb 17, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 17, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants