Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild does not obtain the entry point correctly #51802

Closed
RikkiGibson opened this issue Mar 11, 2021 · 0 comments · Fixed by #51845
Closed

Rebuild does not obtain the entry point correctly #51802

RikkiGibson opened this issue Mar 11, 2021 · 0 comments · Fixed by #51845
Assignees
@RikkiGibson
Labels
Area-Compilers Bug New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations
Milestone
16.10

Comments

@RikkiGibson
Copy link
Contributor

Do we need to handle the case where there are multiple "Main" methods in the type? Could we simply use producedCompilation.GetEntryPoint() instead (and avoid looking at optionsReader as well)?

Originally posted by @cston in #51709 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 11, 2021
@RikkiGibson RikkiGibson added Area-Compilers New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations and removed Area-Infrastructure labels Mar 11, 2021
@RikkiGibson RikkiGibson mentioned this issue Mar 12, 2021
Merged
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 15, 2021
@jaredpar jaredpar added this to the 16.10 milestone Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RikkiGibson RikkiGibson

Labels
Area-Compilers Bug New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations
Projects
None yet
Milestone
16.10
Development

Successfully merging a pull request may close this issue.

Rebuild compilations that use top-level statements RikkiGibson/roslyn
2 participants
@jaredpar @RikkiGibson