Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly pass debugEntryPoint in Rebuild #51895

Open
RikkiGibson opened this issue Mar 15, 2021 · 0 comments
Open

Correctly pass debugEntryPoint in Rebuild #51895

RikkiGibson opened this issue Mar 15, 2021 · 0 comments
Labels
Area-Compilers Bug New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations
Milestone
Backlog

Comments

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Mar 15, 2021 •
edited
Loading

Related to #51845

Our method of getting the debug entry point in the Rebuild utility seems wrong currently. However, when we change it to use the Compilation.GetEntryPoint API, we actually get rebuild failures in projects where the entry point is Task Main() or similar.

We should figure out exactly how to determine the debugEntryPoint from the original compilation and get a symbol for it in the rebuild compilation.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 15, 2021
@RikkiGibson RikkiGibson added the New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations label Mar 17, 2021
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 17, 2021
@jaredpar jaredpar added this to the 16.10 milestone Mar 17, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, 17.0 Jul 16, 2021
@jaredpar jaredpar modified the milestones: 17.0, 17.1 Sep 2, 2021
@jinujoseph jinujoseph modified the milestones: 17.1, 17.3 Apr 27, 2022
@jaredpar jaredpar modified the milestones: 17.3, C# 12.0 Jun 30, 2022
@jaredpar jaredpar modified the milestones: C# 12.0, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jaredpar @RikkiGibson @jinujoseph