Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EnC error messages used for Hot Reload #52018

Closed
tmat opened this issue Mar 20, 2021 · 1 comment
Closed

Update EnC error messages used for Hot Reload #52018

tmat opened this issue Mar 20, 2021 · 1 comment

Comments

@tmat
Copy link
Member

tmat commented Mar 20, 2021

Most rude edits say something like "Changing xyz will prevent the debug session from continuing".
This is not accurate in Hot Reload scenarios - especially not in Ctlr+F5 since there is no debug session.

Proposal

Split the rude edit message into two parts and compose the two resource strings when reporting the diagnostics based on context:

  1. description of the edit being made
  2. why the edit is not allowed
    a) The current message when performing EnC: "will prevent the debug session from continuing" -> "requires restarting the debugging session" "requires restarting the application"
    b) When the capabilities of the runtime do not allow the edit: "... because it is not supported by the runtime"
    c) Hot Reload edit: "requires restarting the application"

Examples:
"Updating a generic method requires restarting the application because it is not supported by the runtime"
"Updating a generic method is not supported by the runtime and requires restarting the debugging session"
"Updating a generic method requires restarting the application"
"Updating a generic method requires restarting the debugging session"

UPDATE:
For simplicity, we'll have the same error message for debugging session and Hot Reload.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 20, 2021
@tmat tmat added this to the 16.10 milestone Mar 20, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 23, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, 17.0 Jul 16, 2021
@jinujoseph jinujoseph modified the milestones: 17.0, 17.0.P3 Jul 21, 2021
@tmat
Copy link
Member Author

tmat commented Jul 22, 2021

Implemented by #55012

@tmat tmat closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants