Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major duplication of loc strings #52343

Closed
CyrusNajmabadi opened this issue Apr 1, 2021 · 4 comments
Closed

Major duplication of loc strings #52343

CyrusNajmabadi opened this issue Apr 1, 2021 · 4 comments
Assignees
@jmarolf
Labels
Area-IDE Bug Tenet-Localization Some piece of UI isn’t localized, often due to hard-coding of strings or other visible elements.
Milestone
17.0.P3

Comments

@CyrusNajmabadi
Copy link
Member

I'm not sure when it happened, but a ton of our loc strings are now duplicated. For example:

  <data name="Prefer_coalesce_expression" xml:space="preserve">
    <value>Prefer coalesce expression</value>
  </data>

Exists now both in EditorFeatures and VSServices.

This is majorly confusing and a maintenance nightmare. We need to unify all these strings.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 1, 2021
@CyrusNajmabadi
Copy link
Member Author

@jmarolf This seems to have been introduced with faf7c13. Can you please take a look and remove the duplication?

@jinujoseph jinujoseph added Bug Tenet-Localization Some piece of UI isn’t localized, often due to hard-coding of strings or other visible elements. and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 7, 2021
@jinujoseph jinujoseph added this to the 16.10 milestone Apr 7, 2021
@Youssef1313 Youssef1313 mentioned this issue Jun 22, 2021
Merged
@CyrusNajmabadi
Copy link
Member Author

@jmarolf can we get eyes on this. This is affecting contributers and leading to problems like loc-string drift. We need to eliminate the dupes here.

@jmarolf
Copy link
Contributor

jmarolf commented Jun 22, 2021

yep on my list to take care of this week

@jinujoseph jinujoseph modified the milestones: 16.10, 17.0, 17.0.P3 Jul 16, 2021
@CyrusNajmabadi
Copy link
Member Author

@jmarolf Can you please address this soon.

@CyrusNajmabadi CyrusNajmabadi mentioned this issue Jul 26, 2021
Merged
2 tasks
@Youssef1313 Youssef1313 mentioned this issue Sep 21, 2021
Open
@jmarolf jmarolf closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarolf jmarolf

Labels
Area-IDE Bug Tenet-Localization Some piece of UI isn’t localized, often due to hard-coding of strings or other visible elements.
Projects
None yet
Milestone
17.0.P3
Development

No branches or pull requests
3 participants
@CyrusNajmabadi @jmarolf @jinujoseph